Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Updates variables used to pull APM branch names #86712

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Dec 21, 2020

Github pull request builder environment variables are not set on master/7.x/etc.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley tylersmalley changed the title [CI] Updates branch env variables [CI] Updates variables used to pull APM branch names Dec 21, 2020
@tylersmalley tylersmalley marked this pull request as ready for review December 22, 2020 00:17
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v7.12.0 v8.0.0 labels Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor Author

@brianseeders can you confirm the environment variables used here?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47143 47903 +760

History

  • 💚 Build #95879 succeeded 04aa83e392a96f6d0d4941d9b4fd0df271918522

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders
Copy link
Contributor

@brianseeders can you confirm the environment variables used here?

Yep, that should be right. And I believe they will have refs/heads/ removed, so e.g. just master

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Bryan confirmed the variable names, LGTM

@tylersmalley tylersmalley merged commit 4f2fd01 into elastic:master Dec 23, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Dec 23, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Dec 23, 2020
tylersmalley pushed a commit that referenced this pull request Dec 23, 2020
tylersmalley pushed a commit that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants