[Security Solution][Resolver] - Maintain active node #86682
Conversation
michaelolo24
added
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
michaelolo24
force-pushed
the
maintain-active-node
branch
from
5a2d303 to
dbc5570
Compare
michaelolo24
added
release_note:enhancement
and removed
release_note:skip
|
@elasticmachine merge upstream |
| payload: nodeID, | ||
| payload: { | ||
| nodeID, | ||
| time: timestamp(), |
There was a problem hiding this comment.
Do we need the time field? I probably missed something but doesn't look like we use it in the reducer right?
There was a problem hiding this comment.
it's used by the animatePanning helper in the reducer https://github.com/elastic/kibana/pull/86682/files#diff-f9c46528634fc1f01e36cc14d7ebcfad609a0ce59c2fcc081520f8e65c0bbc18R69
There was a problem hiding this comment.
Yea, this line specifically:
| import { urlSearch } from '../test_utilities/url_search'; | ||
|
|
||
| const resolverComponentInstanceID = 'useSyncSelectedNodeTestInstanceId'; | ||
| const animationDuration = 1000; |
There was a problem hiding this comment.
I can't remember if it's possible but should we import the duration amount from the resolver code?
There was a problem hiding this comment.
We never made this a constant anywhere, but just did so and updated it in any relevant tests
michaelolo24
force-pushed
the
maintain-active-node
branch
from
89775c0 to
5e82862
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Spoke with @patrykkopycinski and it should remain in there. Reverted my changes to the |
Co-authored-by: Kibana Machine <[email protected]>
…87371) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
Summary
This PR removes the deprecated
userBroughtNodeIntoView, and adds auseSyncSelectedNodeto sync the active node to any url changes that take place via interaction with the graph as well as via the browser back and forward buttons. This also resolves #81189GIF of the forward and back actions below
syncSelected.gif.zip
Checklist
Delete any items that are not applicable to this PR.