[Security Solution] Unskip cypress tests #86653

angorayc · 2020-12-21T15:30:33Z

Summary

This PR is to unskip data provider's Cypress test.

The flakiness in timeline_data_provider.spec may cause by Cypress tries to retrieve the close button before timeline is opened, therefor removing the 1 sec waiting time while opening timeline.
Failing test: "after each" hook for "renders the data provider of a host dragged from the All Hosts widget on the hosts page" - timeline data providers "after each" hook for "renders the data provider of a host dragged from the All Hosts widget on the hosts page" #85098
Failing test: renders the data provider of a host dragged from the All Hosts widget on the hosts page - timeline data providers renders the data provider of a host dragged from the All Hosts widget on the hosts page #62060
Update the data-test-subj for filters of search bar:
x-pack/plugins/security_solution/cypress/screens/timeline.ts Line 109
It added an extra whitespace in the data-test-subj and failed the cypress test, which looks like

data-test-subj="filter filter-enabled filter-key-${filter.field} filter-value-${filter.value} filter-unpinned "

I had a quick fix by adding an extra whitespace in x-pack/plugins/security_solution/cypress/screens/timeline.ts Line 111 in my previous PR to adapt to it, but I don't think that's a good solution.

#79389

patrykkopycinski · 2020-12-21T16:03:24Z

x-pack/plugins/security_solution/cypress/tasks/timeline.ts

@@ -113,6 +113,7 @@ export const checkIdToggleField = () => {
 };

 export const closeTimeline = () => {
+  cy.wait(1000);


maybe we could find another way instead of .wait()?

patrykkopycinski · 2020-12-22T15:00:14Z

x-pack/plugins/security_solution/cypress/tasks/timeline.ts

@@ -166,7 +166,8 @@ export const pinFirstEvent = () => {

 export const populateTimeline = () => {
  executeTimelineKQL(hostExistsQuery);
-  cy.get(SERVER_SIDE_EVENT_COUNT)
+  cy.get(QUERY_TAB_EVENTS_FOOTER)
+    .find(SERVER_SIDE_EVENT_COUNT)


if you want to find SERVER_SIDE_EVENT_COUNT inside QUERY_TAB_EVENTS_FOOTER you should use https://docs.cypress.io/api/commands/within.html#Syntax

https://docs.cypress.io/api/commands/find.html#Syntax looks good to me too.
I am using find as the looks flat, however within seems always follow by a callback.

patrykkopycinski · 2020-12-22T15:04:26Z

src/plugins/data/public/ui/filter_bar/filter_item.tsx

@@ -145,7 +145,14 @@ export function FilterItem(props: Props) {
    const dataTestSubjNegated = filter.meta.negate ? 'filter-negated' : '';
    const dataTestSubjDisabled = `filter-${isDisabled(labelConfig) ? 'disabled' : 'enabled'}`;
    const dataTestSubjPinned = `filter-${isFilterPinned(filter) ? 'pinned' : 'unpinned'}`;
-    return `filter ${dataTestSubjDisabled} ${dataTestSubjKey} ${dataTestSubjValue} ${dataTestSubjPinned} ${dataTestSubjNegated}`;
+    return classNames(


can we limit the scope of the changes to the Security solution plugin only?

yeah I understand, but it added an extra whitespace in the data-test-subj and failed the cypress test.
I had a quick fix by adding an extra whitespace in x-pack/plugins/security_solution/cypress/screens/timeline.ts Line 111 in my previous PR to adapt to it, but I don't think that's a good solution.
#85871

angorayc · 2020-12-23T14:43:22Z

@elasticmachine merge upstream

angorayc · 2020-12-27T20:05:30Z

@elasticmachine merge upstream

angorayc · 2020-12-30T15:35:58Z

@elasticmachine merge upstream

angorayc · 2020-12-30T17:37:20Z

@elasticmachine merge upstream

angorayc · 2020-12-30T23:59:44Z

@elasticmachine merge upstream

angorayc · 2021-01-04T09:36:11Z

@elasticmachine merge upstream

lizozom

Looks correct!

MadameSheema

Lots of thanks for taking the time to fix this :)

angorayc · 2021-01-06T15:43:55Z

@elasticmachine merge upstream

angorayc · 2021-01-07T16:56:48Z

@elasticmachine merge upstream

…ovider

kibanamachine · 2021-01-08T06:29:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1ca8af9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`data`	270.9KB	270.9KB	-34.0B
`securitySolution`	8.5MB	8.5MB	+369.0B
total			+335.0B

History

💔 Build #97613 failed c240357
💔 Build #97321 failed 0f61f66
💚 Build #96565 succeeded 133e674
💚 Build #96486 succeeded 4a9c9e6
💛 Build #96445 was flaky cb2ee11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* unskip data provider cypress test * remove extra whitespace for filter classes * remove cy.wait * update functional test * fix cypress and add tabType to dataTestSubj * fix cypress test * revert createNewTimeline task * fix dependency * fix line error Co-authored-by: Kibana Machine <[email protected]>

* unskip data provider cypress test * remove extra whitespace for filter classes * remove cy.wait * update functional test * fix cypress and add tabType to dataTestSubj * fix cypress test * revert createNewTimeline task * fix dependency * fix line error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

* master: [APM] Define placement “Right” to offset tooltip (elastic#87729) Fix UI glitch on SOM delete confirmation modal (elastic#87623) Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988) [Timelion] Fix tests flakiness on suggestion click (elastic#87273) [Uptime] Fix/details page tabs (elastic#86296) [ML] Fix earliest and latest texts for date fields (elastic#87482) chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765) [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609) [Security Solution] Unskip cypress tests (elastic#86653)

unskip data provider cypress test

14850f6

angorayc requested review from a team as code owners December 21, 2020 15:30

angorayc added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 21, 2020

patrykkopycinski reviewed Dec 21, 2020

View reviewed changes

remove extra whitespace for filter classes

fbcb096

angorayc requested a review from a team as a code owner December 21, 2020 16:27

angorayc added 4 commits December 22, 2020 04:09

remove cy.wait

59821e3

update functional test

1af4bda

fix cypress and add tabType to dataTestSubj

6f5a232

fix cypress test

02e6d32

angorayc changed the title ~~unskip data provider cypress test~~ [Security Solution] Unskip cypress tests Dec 22, 2020

revert createNewTimeline task

4f4d67a

patrykkopycinski reviewed Dec 22, 2020

View reviewed changes

Merge branch 'master' into unskip-dataprovider

f89646d

kibanamachine and others added 4 commits December 27, 2020 15:05

Merge branch 'master' into unskip-dataprovider

8aee256

fix dependency

7daeef0

Merge remote-tracking branch 'upstream/master' into unskip-dataprovider

60f815b

fix line error

e3925b8

angorayc requested a review from MadameSheema December 28, 2020 13:47

angorayc mentioned this pull request Dec 28, 2020

[Security Solution] Fix pop up message #86973

Merged

Merge branch 'master' into unskip-dataprovider

6f5cade

Merge branch 'master' into unskip-dataprovider

cb2ee11

Merge branch 'master' into unskip-dataprovider

4a9c9e6

Merge branch 'master' into unskip-dataprovider

133e674

lizozom approved these changes Jan 4, 2021

View reviewed changes

MadameSheema approved these changes Jan 5, 2021

View reviewed changes

Merge branch 'master' into unskip-dataprovider

0f61f66

kibanamachine and others added 2 commits January 7, 2021 11:57

Merge branch 'master' into unskip-dataprovider

c240357

Merge branch 'master' of github.com:elastic/kibana into unskip-datapr…

1ca8af9

…ovider

angorayc merged commit 4986bea into elastic:master Jan 8, 2021

angorayc mentioned this pull request Jan 8, 2021

[7.x] [Security Solution] Unskip cypress tests (#86653) #87767

Merged

angorayc mentioned this pull request Jan 8, 2021

[7.11] [Security Solution] Unskip cypress tests (#86653) #87768

Merged

oatkiller added the Feature:Timeline Security Solution Timeline feature label Jan 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Unskip cypress tests #86653

[Security Solution] Unskip cypress tests #86653

angorayc commented Dec 21, 2020 •

edited

Loading

patrykkopycinski Dec 21, 2020

patrykkopycinski Dec 22, 2020

angorayc Dec 22, 2020

patrykkopycinski Dec 22, 2020

angorayc Dec 22, 2020 •

edited

Loading

angorayc commented Dec 23, 2020

angorayc commented Dec 27, 2020

angorayc commented Dec 30, 2020

angorayc commented Dec 30, 2020

angorayc commented Dec 30, 2020

angorayc commented Jan 4, 2021

lizozom left a comment

MadameSheema left a comment

angorayc commented Jan 6, 2021

angorayc commented Jan 7, 2021

kibanamachine commented Jan 8, 2021

[Security Solution] Unskip cypress tests #86653

[Security Solution] Unskip cypress tests #86653

Conversation

angorayc commented Dec 21, 2020 • edited Loading

Summary

patrykkopycinski Dec 21, 2020

Choose a reason for hiding this comment

patrykkopycinski Dec 22, 2020

Choose a reason for hiding this comment

angorayc Dec 22, 2020

Choose a reason for hiding this comment

patrykkopycinski Dec 22, 2020

Choose a reason for hiding this comment

angorayc Dec 22, 2020 • edited Loading

Choose a reason for hiding this comment

angorayc commented Dec 23, 2020

angorayc commented Dec 27, 2020

angorayc commented Dec 30, 2020

angorayc commented Dec 30, 2020

angorayc commented Dec 30, 2020

angorayc commented Jan 4, 2021

lizozom left a comment

Choose a reason for hiding this comment

MadameSheema left a comment

Choose a reason for hiding this comment

angorayc commented Jan 6, 2021

angorayc commented Jan 7, 2021

kibanamachine commented Jan 8, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

angorayc commented Dec 21, 2020 •

edited

Loading

angorayc Dec 22, 2020 •

edited

Loading