Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix time scaling bugs #86444

Merged
merged 2 commits into from
Dec 21, 2020
Merged

[Lens] Fix time scaling bugs #86444

merged 2 commits into from
Dec 21, 2020

Conversation

flash1293
Copy link
Contributor

Fixes #86440
Fixes #85894

This PR fixes two small issues with time scaling:

  • If there's an empty string returned from the underlying formatter it doesn't make sense to add a suffix. To test this, set line 136 in x-pack/plugins/lens/public/indexpattern_datasource/time_scale.ts to newRow[outputColumnId] = undefined;, then configure a table vis with a normalized by unit metric dimension
  • Make sure the label is set correctly when applying time scaling

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.11.0 v7.12.0 labels Dec 18, 2020
@flash1293 flash1293 marked this pull request as ready for review December 18, 2020 13:32
@flash1293 flash1293 requested a review from a team December 18, 2020 13:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon
wylieconlon approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested that the label is set correctly and that it doesn't show values when empty. Did not test against the reference editing branch.

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB +62.0B

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 36a8343 into elastic:master Dec 21, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Dec 21, 2020
@flash1293
fix time scaling bugs (elastic#86444)
0ed4cb1
@flash1293 flash1293 mentioned this pull request Dec 21, 2020
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Dec 21, 2020
@flash1293
fix time scaling bugs (elastic#86444)
22f249b
@flash1293 flash1293 mentioned this pull request Dec 21, 2020
Merged
flash1293 added a commit that referenced this pull request Dec 21, 2020
@flash1293
fix time scaling bugs (#86444) (#86643)
a4e9975
flash1293 added a commit that referenced this pull request Dec 22, 2020
@flash1293
fix time scaling bugs (#86444) (#86644)
d1e9772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@flash1293 @elasticmachine @kibanamachine @wylieconlon