Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates elasticsearch client in the settings usage collector #86397

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Migrates elasticsearch client in the settings usage collector #86397

merged 3 commits into from
Dec 18, 2020

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Dec 17, 2020 •
edited
Loading

Summary

Uses the new elasticsearch client in the settings usage_collector.
Part of #86358

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@TinaHeiligers TinaHeiligers added Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0 labels Dec 17, 2020
@TinaHeiligers TinaHeiligers added the release_note:skip Skip the PR/issue when compiling release notes label Dec 17, 2020
afharo
afharo approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed by how fast you put these changes together! Well done!

It's a pity the new client does not return the correct types in the info request. Hopefully, it'll be improved in the near future.

Once the comment is tackled, it LGTM!

x-pack/plugins/xpack_legacy/server/routes/settings.ts Outdated Show resolved Hide resolved
@TinaHeiligers TinaHeiligers marked this pull request as ready for review December 18, 2020 15:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 0155974 into elastic:master Dec 18, 2020
@TinaHeiligers TinaHeiligers deleted the settings-collector-to-new-es-client branch December 18, 2020 17:53
@TinaHeiligers TinaHeiligers mentioned this pull request Dec 18, 2020
Merged
TinaHeiligers added a commit that referenced this pull request Dec 18, 2020
@TinaHeiligers
[7.x] Migrates elasticsearch client in the settings usage collector (#…
68f8cf8 
…86397) (#86493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TinaHeiligers @elasticmachine @kibanamachine @afharo