Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PR #8208 to 5.x - Add comments and inline docs for visualization saving and editing process. #8625

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

elastic-jasper
Copy link
Contributor

Backport PR #8208

Commit 1:
Add comments and inline docs for visualization saving and editing process.
The goal is to clarify where URL state is coming from, when working with
visualizations. Some of the classes touched upon are: SavedVis,
PersistedState, AppState, and base classes.

Explored files:

  • src/core_plugins/kibana/public/visualize/editor/editor.js
  • src/core_plugins/kibana/public/visualize/saved_visualizations/_saved_vis.js
  • src/ui/public/courier/data_source/_doc_send_to_es.js
  • src/ui/public/courier/data_source/doc_source.js
  • src/ui/public/courier/saved_object/saved_object.js
  • src/ui/public/es.js
  • src/ui/public/events.js
  • src/ui/public/persisted_state/persisted_state.js
  • src/ui/public/state_management/app_state.js
  • src/ui/public/state_management/state.js
  • src/ui/public/vis/agg_config.js
  • src/ui/public/vis/agg_configs.js
  • src/ui/public/vis/vis.js
  • Original sha: 34e3f49
  • Authored by CJ Cenizal [email protected] on 2016-08-10T00:10:48Z

---------

**Commit 1:**
Add comments and inline docs for visualization saving and editing process.
The goal is to clarify where URL state is coming from, when working with
visualizations. Some of the classes touched upon are: SavedVis,
PersistedState, AppState, and base classes.

Explored files:
- src/core_plugins/kibana/public/visualize/editor/editor.js
- src/core_plugins/kibana/public/visualize/saved_visualizations/_saved_vis.js
- src/ui/public/courier/data_source/_doc_send_to_es.js
- src/ui/public/courier/data_source/doc_source.js
- src/ui/public/courier/saved_object/saved_object.js
- src/ui/public/es.js
- src/ui/public/events.js
- src/ui/public/persisted_state/persisted_state.js
- src/ui/public/state_management/app_state.js
- src/ui/public/state_management/state.js
- src/ui/public/vis/agg_config.js
- src/ui/public/vis/agg_configs.js
- src/ui/public/vis/vis.js

* Original sha: 34e3f49
* Authored by CJ Cenizal <[email protected]> on 2016-08-10T00:10:48Z
@cjcenizal cjcenizal changed the title [backport] PR #8208 to 5.x [backport] PR #8208 to 5.x - Add comments and inline docs for visualization saving and editing process. Oct 11, 2016
@cjcenizal cjcenizal merged commit 8752eea into 5.x Oct 11, 2016
@cjcenizal cjcenizal deleted the jasper/backport/8208/5.x branch October 11, 2016 19:43
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[backport] PR elastic#8208 to 5.x - Add comments and inline docs for visualization saving and editing process.

Former-commit-id: 8752eea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants