Attempt to stabilize cloneIndex integration tests #86123

rudolf · 2020-12-16T15:29:45Z

Summary

Fixes #86068 #86350

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-12-17T06:42:10Z

Pinging @elastic/kibana-core (Team:Core)

afharo

We are not awaiting expect().resolves. Tests might be succeeding when they are not actually resolving the expected behaviour.

src/core/server/saved_objects/migrationsv2/integration_tests/actions.test.ts

pgayvallet · 2020-12-18T09:39:21Z

@rudolf did you run the branch against the flaky test runner?

rudolf · 2020-12-18T09:46:21Z

@rudolf did you run the branch against the flaky test runner?

We can't currently select jest_integration tests on the flaky test runner and because of the migration to Teamcity it doesn't make so much sense to add this to Jenkins right now. So I told the ops team I'll see if I can fix this but if the test becomes flaky again I'll ask them to add this to the Jenkins flaky test runner.

src/core/server/saved_objects/migrationsv2/integration_tests/actions.test.ts

kibanamachine · 2020-12-18T13:28:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ee7e5f5

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	47287	48047	+760

History

💚 Build #95349 succeeded bc5501b
💚 Build #95174 succeeded 50e998b
💚 Build #94898 succeeded 4cdb4c4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rudolf · 2020-12-18T13:37:20Z

Will backport into 7.x as part of #86284 to prevent introducing unstable tests into 7.x

* Attempt to stabilize cloneIndex integration tests * Unskip test * return resolves/rejects and add assertions counts to each test * Await don't return expect promises * Await don't return expect promises for other tests too

* Resilient saved object migration algorithm (#78413) * Initial structure of migration state-action machine * Fix type import * Retries with exponential back off * Use discriminated union for state type * Either type for actions * Test exponential retries * TaskEither types for actions * Fetch indices instead of aliases so we can collect all index state in one request * Log document id if transform fails * WIP: Legacy pre-migrations * UPDATE_TARGET_MAPPINGS * WIP OUTDATED_DOCUMENTS_TRANSFORM * Narrow res types depending on control state * OUTDATED_DOCUMENTS_TRANSFORM * Use .kibana instead of .kibana_current * rename control states TARGET_DOCUMENTS* -> OUTDATED_DOCUMENTS* * WIP MARK_VERSION_INDEX_READY * Fix and expand INIT -> * transition tests * Add alias/index name helper functions * Add feature flag for enabling v2 migrations * split state_action_machine, reindex legacy indices * Don't use a scroll search for migrating outdated documents * model: test control state progressions * Action integration tests * Fix existing tests and type errors * snapshot_in_progress_exception can only happen when closing/deleting an index * Retry steps up to 10 times * Update api.md documentation files * Further actions integration tests * Action unit tests * Fix actions integration tests * Rename actions to be more domain-specific * Apply suggestions from code review Co-authored-by: Josh Dover <[email protected]> * Review feedback: polish and flesh out inline comments * Fix unhandled rejections in actions unit tests * model: only delay retryable_es_client_error, reset for other left responses * Actions unit tests * More inline comments * Actions: Group index settings under 'index' key * bulkIndex -> bulkOverwriteTransformedDocuments to be more domain specific * state_action_machine tests, fix and add additional tests * Action integration tests: updateAndPickupMappings, searchForOutdatedDocuments * oops: uncomment commented out code * actions integration tests: rejection for createIndex * update state properties: clearer names, mark all as readonly * add state properties currentAlias, versionAlias, legacyIndex and test for invalid version scheme in index names * Use CONSTANTS for constants :D * Actions: Clarify behaviour and impact of acknowledged: false responses * Use consistent vocabulary for action responses * KibanaMigrator test for migrationsV2 * KibanaMigrator test for FATAL state and action exceptions in v2 migrations * Fix ts error in test * Refactor: split index file up into a file per model, next, types * next: use partial application so we don't generate a nextActionMap on every call * move logic from index.ts to migrations_state_action_machine.ts and test * add test * use `Root` to allow specifying oss mode * Add fix and todo tests for reindexing with preMigrationScript * Dump execution log of state transitions and responses if we hit FATAL * add 7.3 xpack tests * add 100k test data * Reindex instead of cloning for migrations * Skip 100k x-pack integration test * MARK_VERSION_INDEX_READY_CONFLICT for dealing with different versions migrating in parallel * Track elapsed time * Fix tests * Model: make exhaustiveness checks more explicit * actions integration tests: add additional tests from CR * migrations_state_action_machine fix flaky test * Fix flaky integration test * Reserve FATAL termination only for situations which we never can recover from such as later version already migrated the index * Handle incompatible_mapping_exception caused by another instance * Cleanup logging * Fix/stabilize integration tests * Add REINDEX_SOURCE_TO_TARGET_VERIFY step * Strip tests archives of */.DS_Store and __MAC_OSX * Task manager migrations: remove invalid kibana property when converting legacy indices * Add disabled mappings for removed field in map saved object type * verifyReindex action: use count API * REINDEX_BLOCK_* to prevent lost deletes (needs tests) * Split out 100k docs integration test so that it has it's own kibana process * REINDEX_BLOCK_* action tests * REINDEX_BLOCK_* model tests * Include original error message when migration_state_machine throws * Address some CR nits * Fix TS errors * Fix bugs * Reindex then clone to prevent lost deletes * Fix tests Co-authored-by: Josh Dover <[email protected]> Co-authored-by: pgayvallet <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # rfcs/text/0013_saved_object_migrations.md * createRootWithCorePlugins support for cliArgs which wasn't backported to 7.x * Attempt to stabilize cloneIndex integration tests (#86123) * Attempt to stabilize cloneIndex integration tests * Unskip test * return resolves/rejects and add assertions counts to each test * Await don't return expect promises * Await don't return expect promises for other tests too * Remove 8.0.0 integration test

kibanamachine · 2020-12-22T13:34:39Z