Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix functional tests for index based Data Visualizer #86071

Merged
merged 12 commits into from
Dec 17, 2020
Merged

[ML] Fix functional tests for index based Data Visualizer #86071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4880ccd
[ML] Rename subjects, remove documentCountCard, add ensureDetailsClosed
qn895 Dec 15, 2020
a9e37f3
[ML] Add content assertions
qn895 Dec 16, 2020
6564e92
[ML] Fix assertDateFieldContents
qn895 Dec 16, 2020
d9c27d7
Merge remote-tracking branch 'upstream/master' into ml-functional-tes…
qn895 Dec 16, 2020
0e28362
[ML] Remove openDetails, add ensureDetailsClosed
qn895 Dec 16, 2020
0874475
[ML] Rename multiselect objs, remove card
qn895 Dec 16, 2020
c636dc1
[ML] Move some methods to table service
qn895 Dec 16, 2020
a17d93d
[ML] Add 'checked' marker to multi select comp
qn895 Dec 16, 2020
a64d33a
[ML] Remove dataVisualizerTable arg
qn895 Dec 16, 2020
5581931
[ML] Move setMultiSelectFilter, removeMultiSelectFilter to mlCommonU…
qn895 Dec 17, 2020
e27e7da
Merge remote-tracking branch 'upstream/master' into ml-functional-tes…
qn895 Dec 17, 2020
deb86fd
Merge branch 'master' into ml-functional-test-data-viz
kibanamachine Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions x-pack/plugins/ml/public/application/components/multi_select_picker/multi_select_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const MultiSelectPicker: FC<{

const button = (
<EuiFilterButton
data-test-subj={`${dataTestSubj}-button`}
iconType="arrowDown"
onClick={onButtonClick}
isSelected={isPopoverOpen}
Expand All @@ -98,32 +99,41 @@ export const MultiSelectPicker: FC<{
return (
<EuiFilterGroup data-test-subj={dataTestSubj}>
<EuiPopover
data-test-subj={`${dataTestSubj}-popover`}
id="popoverExampleMultiSelect"
button={button}
isOpen={isPopoverOpen}
closePopover={closePopover}
panelPaddingSize="none"
>
<EuiPopoverTitle paddingSize="s">
<EuiFieldSearch compressed onChange={(e) => setSearchTerm(e.target.value)} />
<EuiFieldSearch
compressed
onChange={(e) => setSearchTerm(e.target.value)}
data-test-subj={`${dataTestSubj}-searchInput`}
/>
</EuiPopoverTitle>
<div style={{ maxHeight: 250, overflow: 'auto' }}>
{Array.isArray(items) && items.length > 0 ? (
items.map((item, index) => (
<EuiFilterSelectItem
checked={
checkedOptions &&
checkedOptions.findIndex((fieldValue) => fieldValue === item.value) > -1
? 'on'
: undefined
}
key={index}
onClick={() => handleOnChange(index)}
style={{ flexDirection: 'row' }}
>
{item.name ?? item.value}
</EuiFilterSelectItem>
))
items.map((item, index) => {
const checked =
checkedOptions &&
checkedOptions.findIndex((fieldValue) => fieldValue === item.value) > -1;

return (
<EuiFilterSelectItem
checked={checked ? 'on' : undefined}
key={index}
onClick={() => handleOnChange(index)}
style={{ flexDirection: 'row' }}
data-test-subj={`${dataTestSubj}-option-${item.value}${
checked ? '-checked' : ''
}`}
>
{item.name ?? item.value}
</EuiFilterSelectItem>
);
})
) : (
<NoFilterItems />
)}
Expand Down
2 changes: 1 addition & 1 deletion ...izer/index_based/components/field_data_card/document_count_chart/document_count_chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const DocumentCountChart: FC<Props> = ({
const dateFormatter = niceTimeFormatter([timeRangeEarliest, timeRangeLatest]);

return (
<div style={{ width: width ?? '100%' }} data-test-subj="mlFieldDataCardDocumentCountChart">
<div style={{ width: width ?? '100%' }} data-test-subj="mlFieldDataDocumentCountChart">
<Chart
size={{
width: '100%',
Expand Down
2 changes: 1 addition & 1 deletion ...ion/datavisualizer/index_based/components/field_data_card/examples_list/examples_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ExamplesList: FC<Props> = ({ examples }) => {
});

return (
<div data-test-subj="mlFieldDataCardExamplesList">
<div data-test-subj="mlFieldDataExamplesList">
<ExpandedRowFieldHeader>
<FormattedMessage
id="xpack.ml.fieldDataCard.examplesList.title"
Expand Down
2 changes: 1 addition & 1 deletion ..._based/components/field_data_card/metric_distribution_chart/metric_distribution_chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const MetricDistributionChart: FC<Props> = ({
};

return (
<div data-test-subj="mlFieldDataCardMetricDistributionChart">
<div data-test-subj="mlFieldDataMetricDistributionChart">
<Chart size={{ width, height }}>
<Settings
theme={{
Expand Down
4 changes: 2 additions & 2 deletions ...plication/datavisualizer/index_based/components/field_data_card/top_values/top_values.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const TopValues: FC<Props> = ({ stats, fieldFormat, barColor, compressed
} = stats;
const progressBarMax = isTopValuesSampled === true ? topValuesSampleSize : count;
return (
<div data-test-subj="mlFieldDataCardTopValues">
<div data-test-subj="mlFieldDataTopValues">
{Array.isArray(topValues) &&
topValues.map((value: any) => (
<EuiFlexGroup gutterSize="xs" alignItems="center" key={value.key}>
Expand All @@ -64,7 +64,7 @@ export const TopValues: FC<Props> = ({ stats, fieldFormat, barColor, compressed
</EuiText>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem data-test-subj="mlFieldDataCardTopValueBar">
<EuiFlexItem data-test-subj="mlFieldDataTopValueBar">
<EuiProgress value={value.doc_count} max={progressBarMax} color={barColor} size="m" />
</EuiFlexItem>
<EuiFlexItem
Expand Down
2 changes: 1 addition & 1 deletion ...cation/datavisualizer/stats_datagrid/components/field_data_row/number_content_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const NumberContentPreview: FC<FieldDataCardProps> = ({ config }) => {
const defaultChartData: MetricDistributionChartData[] = [];
const [distributionChartData, setDistributionChartData] = useState(defaultChartData);
const [legendText, setLegendText] = useState<{ min: number; max: number } | undefined>();
const dataTestSubj = fieldName;
const dataTestSubj = `mlDataGridChart-${fieldName}`;
useEffect(() => {
const chartData = buildChartDataFromStats(stats, METRIC_DISTRIBUTION_CHART_WIDTH);
if (
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/datavisualizer/stats_datagrid/expanded_row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DataVisualizerFieldExpandedRow = ({ item }: { item: FieldVisConfig
return (
<div
className="mlDataVisualizerFieldExpandedRow"
data-test-subj={`mlDataVisualizerFieldExpandedRow ${fieldName} ${type}`}
data-test-subj={`mlDataVisualizerFieldExpandedRow-${fieldName}`}
>
{loading === true ? <LoadingIndicator /> : getCardContent()}
</div>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/datavisualizer/stats_datagrid/stats_datagrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export const DataVisualizerDataGrid = ({
const direction = expandedRowItemIds.includes(item.fieldName) ? 'arrowUp' : 'arrowDown';
return (
<EuiButtonIcon
data-test-subj={`mlDataVisualizerToggleDetails ${item.fieldName} ${direction}`}
data-test-subj={`mlDataVisualizerDetailsToggle-${item.fieldName}-${direction}`}
onClick={() => toggleDetails(item)}
aria-label={
expandedRowItemIds.includes(item.fieldName)
Expand Down
Loading