Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix broken link to ML when time range is not set #85976

Merged
merged 2 commits into from
Dec 16, 2020
Merged

[APM] Fix broken link to ML when time range is not set #85976

merged 2 commits into from
Dec 16, 2020

Conversation

sorenlouv
Copy link
Member

Closes #85025

The Anomaly Detection page in APM doesn't have a time range defined causing the ML links to fail.
This PR uses the default Kibana timepicker settings when not set.

@sorenlouv sorenlouv requested a review from a team as a code owner December 15, 2020 16:37
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor

@sqren does it also fixes the Machine Learning link on the Settings page?

@sorenlouv
Copy link
Member Author

does it also fixes the Machine Learning link on the Settings page?

@cauemarcondes I've now taken all of the ML links into account. Thanks for the heads up.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1730 1729 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +625.0B

Distributable file count

id before after diff
default 47241 48001 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes
cauemarcondes approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv
Copy link
Member Author

jenkins run the e2e

@sorenlouv sorenlouv merged commit 744d680 into elastic:master Dec 16, 2020
@sorenlouv sorenlouv deleted the fix-ml-link branch December 16, 2020 15:17
@sorenlouv sorenlouv mentioned this pull request Dec 16, 2020
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Dec 16, 2020
@sorenlouv
[APM] Fix broken link to ML when time range is not set (elastic#85976)
73424f5
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Dec 16, 2020
@sorenlouv
[APM] Fix broken link to ML when time range is not set (elastic#85976)
f670b15
@sorenlouv sorenlouv mentioned this pull request Dec 16, 2020
Merged
sorenlouv added a commit that referenced this pull request Dec 17, 2020
@sorenlouv
[APM] Fix broken link to ML when time range is not set (#85976) (#86228)
c6c0015
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 18, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 22, 2020
cauemarcondes pushed a commit that referenced this pull request Dec 22, 2020
@sorenlouv @kibanamachine
[APM] Fix broken link to ML when time range is not set (#85976) (#86227)
2d361f0 
Co-authored-by: Kibana Machine <[email protected]>
@cauemarcondes cauemarcondes mentioned this pull request Dec 22, 2020
Closed
@cauemarcondes cauemarcondes self-assigned this Dec 28, 2020
@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Dec 28, 2020
@cauemarcondes
Copy link
Contributor

Tests ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@smith smith smith approved these changes

Assignees

@cauemarcondes cauemarcondes

Labels
apm:test-plan-7.11.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Link to ML Job is broken
5 participants
@sorenlouv @elasticmachine @cauemarcondes @kibanamachine @smith