-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Embeddable Toolbar #85663
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
dashboard/embeddable-bar
branch
from
December 16, 2020 18:07
fa54fb2
to
0638521
Compare
cqliu1
force-pushed
the
dashboard/embeddable-bar
branch
from
January 11, 2021 17:18
0638521
to
a2f8f6d
Compare
💔 Build Failed
Failed CI Steps
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/embeddable/save_and_return·js.maps app embeddable save and return work flow new map "before each" hook for "should return to dashboard and add new panel"Standard Out
Stack Trace
Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/dashboard·ts.lens app lens dashboard tests should not carry over filters if creating a new lens visualization from within dashboardStandard Out
Stack Trace
Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_empty_screen·js.dashboard mode empty dashboard adds Lens visualization to empty dashboardStandard Out
Stack Trace
and 7 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #85666.
Related to #81812.
This creates a shared embeddable toolbar component that handles creating new embeddables and adding existing embeddables for presentation apps.
Checklist
Delete any items that are not applicable to this PR.
For maintainers