Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent #85646

Merged
merged 2 commits into from
Dec 16, 2020
Merged

[APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent #85646

merged 2 commits into from
Dec 16, 2020

Conversation

mikker
Copy link

@mikker mikker commented Dec 10, 2020 •
edited
Loading

@mikker mikker requested a review from a team December 10, 2020 21:12
@mikker mikker self-assigned this Dec 10, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@mikker mikker mentioned this pull request Dec 10, 2020
Closed
@mikker mikker changed the title [APM] Add sanitize_field_names config option to Ruby agent [APM] Add sanitize_field_names and transaction_ignore_urls config option to Ruby agent Dec 14, 2020
@mikker mikker changed the title [APM] Add sanitize_field_names and transaction_ignore_urls config option to Ruby agent [APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent Dec 14, 2020
@mikker
Copy link
Author

mikker commented Dec 15, 2020

@sqren This ok to merge?

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

This ok to merge?

Ok to merge when CI passes. Not sure what the problem is but tried to kick it. Let's see

@smith
Copy link
Contributor

smith commented Dec 15, 2020

API test failures were due to 503s.

retest

@smith
Copy link
Contributor

smith commented Dec 15, 2020

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 39543e8 into elastic:master Dec 16, 2020
@sorenlouv sorenlouv mentioned this pull request Dec 16, 2020
Merged
@mikker mikker deleted the remote-config branch December 16, 2020 09:09
sorenlouv added a commit that referenced this pull request Dec 17, 2020
@sorenlouv @kibanamachine
[APM] Add sanitize_field_names and transaction_ignore_urls config opt…
8fce386 
…ions to Ruby agent (#85646) (#86084)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Mikkel Malmberg <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@mikker mikker

Labels
agent-ruby release_note:enhancement Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
5 participants
@mikker @elasticmachine @sorenlouv @smith @kibanamachine