Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security_Solution][Endpoint] Register Custom tab into Fleet Endpoint Integration Detail #85643

Merged
merged 21 commits into from
Dec 14, 2020
Merged

[Security_Solution][Endpoint] Register Custom tab into Fleet Endpoint Integration Detail #85643

merged 21 commits into from
Dec 14, 2020

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Dec 10, 2020 •
edited
Loading

Summary

Fleet:

  • Changes the Custom UI Extension so that package information is passed on as props to the registered custom UI compoennt

Endpoint:

  • Register a Custom Integration view for on Fleet's Endpoint Integration Details. View shows a Trusted Application entry that allows the user to navigate to the Trusted Application page in Security Solution.
  • Removes the Blue Callout currently displayed on a Fleet edit Endpoint Policy that provided the user with an means to navigate to trusted apps.

olm-512-custom-tab-in-fleet

Checklist

@paul-tavares
Register UI Extension with fleet for endpoint custom content
fe1af85
@paul-tavares
Fleet: add component props to the Package Custom UI extension
7be498e
@paul-tavares
Endpoint: initial UI for Trusted Apps custom entry
6de3686
@paul-tavares
Merge remote-tracking branch 'upstream/master' into task/olm-512-cust…
5bbbbba 
…om-tab-in-fleet
@paul-tavares
Fleet: fix up pkgkey generation in epm detials
c874789
@paul-tavares
Fleet: epm detail content show full width for custom tab
0a3c98f
@paul-tavares
UI for link to trusted apps
e82498b
@paul-tavares
Move custom extension to its own dir
d82ab72
@paul-tavares
Merge remote-tracking branch 'upstream/master' into task/olm-512-cust…
d3bc7e6 
…om-tab-in-fleet
@paul-tavares
Refactor to have each card separate
e81be37
@paul-tavares
more refactor
596542a
@paul-tavares
Styled trusted app card items summary
9b5603a
@paul-tavares
delete package policy edit page callout
9e6fe85
@paul-tavares
remove edit package policy callout tests
5fdb9d0
@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Dec 10, 2020
@paul-tavares paul-tavares self-assigned this Dec 10, 2020
@paul-tavares paul-tavares requested a review from a team as a code owner December 10, 2020 20:58
@paul-tavares paul-tavares requested a review from a team December 10, 2020 20:58
@paul-tavares paul-tavares requested a review from a team as a code owner December 10, 2020 20:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@paul-tavares
Copy link
Contributor Author

NOTE: I'm currently writing some Functional test cases from the Endpoint side to validate that the custom content is displayed as we expect it. Will have that come through soon, but wanted to get this out there for review since the code is "done" :)

nchaulet
nchaulet approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet part 🚀

kevinlog
kevinlog approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pzl
pzl approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@paul-tavares
Copy link
Contributor Author

jenkins test this

@paul-tavares paul-tavares merged commit f6cd264 into elastic:master Dec 14, 2020
@paul-tavares paul-tavares deleted the task/olm-512-custom-tab-in-fleet branch December 14, 2020 22:09
@paul-tavares paul-tavares mentioned this pull request Dec 14, 2020
Merged
paul-tavares added a commit that referenced this pull request Dec 15, 2020
@paul-tavares @kibanamachine
[Security_Solution][Endpoint] Register Custom tab into Fleet Endpoint…
8fc36d3 
… Integration Detail (#85643) (#85877)

* Fleet: add component props to the Package Custom UI extension
* Endpoint: Register UI Extension with fleet for endpoint custom content
* Endpoint: UI for Trusted Apps custom entry

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2124 2129 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 950.4KB 950.3KB -170.0B
securitySolution 8.3MB 8.3MB +25.4KB
total +25.2KB

Distributable file count

id before after diff
default 47138 47901 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 376.5KB 377.1KB +599.0B
securitySolution 215.7KB 219.5KB +3.8KB
total +4.4KB
Unknown metric groups

async chunk count

id before after diff
securitySolution 22 23 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@nchaulet nchaulet nchaulet approved these changes

@pzl pzl pzl approved these changes

Assignees

@paul-tavares paul-tavares

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paul-tavares @elasticmachine @kibanamachine @pzl @nchaulet @kevinlog