Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Document the "Other" entry in data summaries in Kibana guide #85575

Merged
merged 9 commits into from
Dec 15, 2020

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 10, 2020

Summary

Fix #81677

Since the issue has been created the Lens UI changed introducing the Other entry to fill the gap until 100% of the value. The missing bit was some documentation to cover the meaning of this special entry, provided by this PR.

Checklist

  • Documentation was added for features that require explanation or tutorials

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens docs v7.11.0 labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611 dej611 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 10, 2020
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor suggestion around punctuation and using active voice, but otherwise, LGTM!

Also, can you add a screenshot that shows this?

@@ -228,6 +228,8 @@ To view the data field summary information, navigate to the field, then click *i
[role="screenshot"]
image::images/lens_data_info.png[Data summary window]

Sometimes documents have no data for the field inspected: *Lens* will show a "Other" entry to represent these documents in the distribution chart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sometimes documents have no data for the field inspected: *Lens* will show a "Other" entry to represent these documents in the distribution chart.
Sometimes documents have no data for the field inspected:. *Lens* shows an *Other* entry to represent these documents in the distribution chart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot that shows this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the screenshot for it, but then dropped as I thought it was too much. Will add it back! 📸

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wylieconlon knows better, but I don't think "Sometimes documents have no data for the field inspected: Lens shows an "Other" entry to represent these documents in the distribution chart." is 100% (pun intended) true - the field summary will only give you 10 entries at max, grouping everything else into "Other":
Screenshot 2020-12-14 at 14 40 37

@dej611
Copy link
Contributor Author

dej611 commented Dec 14, 2020

Ok, found out the 10 value in the server code. Will update on that side as well.

[role="screenshot"]
image::images/lens_data_info_other.png[Data summary window with Other]

NOTE: because the distribution is based on single values, the sum of all the entries and "Other" may be above 100%, because entries in array values are counted as distinct values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test and while Tim raises a good point in the issue you opened, this is not the case right now:
Screenshot 2020-12-14 at 15 25 17

For this data:

POST testindex/_doc
{
  "val": ["A", "B", "C"]
}

POST testindex/_doc
{
  "val": ["D", "E", "F"]
}

POST testindex/_doc
{
  "val": ["G", "H", "I"]
}

Right now it seems like this only caused by rounding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up on this discussion: @flash1293 is right that it's only a rounding issue, not an issue with the underlying calculation. The size of "other" is based on the value_count of the field minus the sum of all terms we get back, which is correct for array fields and regular fields.

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we're updating this part of the docs, but I think it needs another round of updates for accuracy!

[role="screenshot"]
image::images/lens_data_info_other.png[Data summary window with Other]

NOTE: because the distribution is based on single values, the sum of all the entries and "Other" may be above 100%, because entries in array values are counted as distinct values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up on this discussion: @flash1293 is right that it's only a rounding issue, not an issue with the underlying calculation. The size of "other" is based on the value_count of the field minus the sum of all terms we get back, which is correct for array fields and regular fields.

@@ -228,6 +228,13 @@ To view the data field summary information, navigate to the field, then click *i
[role="screenshot"]
image::images/lens_data_info.png[Data summary window]

*Lens* inspects the top 10 values to build the value distribution: every other value, together with documents with no data for the inspected field, are shown with the "Other" entry in the distribution chart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is missing information about what happens for number/date fields: in both cases we do something more than just top 10. For numbers we show both top 10 and histogram. We show the histogram when the top 10 values are less than 10% of all the values.

@dej611
Copy link
Contributor Author

dej611 commented Dec 15, 2020

I've revisited completely the data summary section to cover all the raised questions and feedback.

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Left a couple of tweaks that you can optionally take

docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
@dej611 dej611 merged commit 56ad415 into elastic:master Dec 15, 2020
@dej611 dej611 deleted the doc/lens/summaries branch December 15, 2020 17:50
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 17, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85575 or prevent reminders by adding the backport:skip label.

dej611 added a commit to dej611/kibana that referenced this pull request Dec 17, 2020
…lastic#85575)

* 📝 Address Other entry in data summaries

* 👌 Integrated feedback from review

* 📝 Add not about going beyong 100% with array values

* 👌 Improved documentation for summaries

* 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

dej611 added a commit that referenced this pull request Dec 21, 2020
…guide (#85575) (#86344)

* 📝 Address Other entry in data summaries

* 👌 Integrated feedback from review

* 📝 Add not about going beyong 100% with array values

* 👌 Improved documentation for summaries

* 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>
dej611 added a commit that referenced this pull request Dec 21, 2020
…uide (#85575) (#86345)

* 📝 Address Other entry in data summaries

* 👌 Integrated feedback from review

* 📝 Add not about going beyong 100% with array values

* 👌 Improved documentation for summaries

* 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Wylie Conlon <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Misleading percentages shown in field stats when the field is only on some docs
6 participants