-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Use eui component instead of custom color stops #85239
[Lens] Use eui component instead of custom color stops #85239
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
))} | ||
</EuiFlexGroup> | ||
<div className="lnsLayerPanel__paletteContainer"> | ||
<EuiColorPaletteDisplay size="xs" palette={accessorConfig.palette} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change, @flash1293. Super minor nitpick, but any chance we can do the following to apply two small style overrides to this EuiColorPaletteDisplay
(to make it look more at home in the dimension item)?
- Apply a
className="lnsLayerPanel__palette"
toEuiColorPaletteDisplay
. - Apply the following styles to this class to adjust the border radius and remove the border:
.lnsLayerPanel__palette {
border-radius: 0 0 ($euiBorderRadius - 1px) ($euiBorderRadius - 1px);
&::after {
border: none;
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @flash1293 I wanted to check your PR already with changes @MichaelMarcialis asked for so I submitted a PR to this branch so you don't have to do the same job- feel free to merge my PR to your branch - changes lgtm, tested on FF and Chrome.
Design border changes
Thank you so much @mbondyra 💚 |
@elasticmachine merge upstream |
This looks lovely. Thanks for making that tweak, @mbondyra! |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
This PR removes the custom logic to show the chosen palette in the dimension and switches to the eui component
EuiColorPaletteDisplay