New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Fixes and unskips 'Exports a custom rule' failing test #85235

Merged

MadameSheema merged 1 commit into elastic:master from MadameSheema:fixes-export-rule

Dec 8, 2020

Member

MadameSheema commented Dec 8, 2020 •

edited

Loading

Summary

Fixes and unskips 'Exports a custom rule' cypress tests.


          fixes and unskips failing test

e721be9

MadameSheema self-assigned this

MadameSheema added release_note:skip Team: SecuritySolution Team:Detections and Resp v7.11.0 v8.0.0 labels

MadameSheema marked this pull request as ready for review

December 8, 2020 09:30

MadameSheema requested review from a team as code owners

December 8, 2020 09:30

patrykkopycinski approved these changes

View reviewed changes

Contributor

kibanamachine commented Dec 8, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e721be9

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	46934	47694	+760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MadameSheema merged commit 273363a into elastic:master

MadameSheema deleted the fixes-export-rule branch

December 8, 2020 13:48

MadameSheema mentioned this pull request

Failing test: "before all" hook for "Exports a custom rule" - Export rules "before all" hook for "Exports a custom rule" #85217

Closed

MadameSheema added a commit to MadameSheema/kibana that referenced this pull request


          fixes and unskips failing test (elastic#85235)

MadameSheema mentioned this pull request

[7.x] fixes and unskips failing test (#85235) #85278

Merged

This was referenced Dec 9, 2020

Failing test: "after each" hook for "Creates and activates a new Indicator Match rule" - Detection rules, Indicator Match "after each" hook for "Creates and activates a new Indicator Match rule" #85216

Closed

Failing test: Creates and activates a new Indicator Match rule - Detection rules, Indicator Match Creates and activates a new Indicator Match rule #85215

Closed

Failing test: "before each" hook for "Allows a rule to be edited" - Custom detection rules deletion and edition Edition "before each" hook for "Allows a rule to be edited" #84027

Closed

Failing test: "before each" hook for "Open one alert when more than one closed alerts are selected" - Alerts Opening alerts "before each" hook for "Open one alert when more than one closed alerts are selected" #83774

Closed

Failing test: "before each" hook for "Mark one alert in progress when more than one open alerts are selected" - Alerts Marking alerts as in-progress "before each" hook for "Mark one alert in progress when more than one open alerts are selected" #83775

Closed

Failing test: "before each" hook for "Closes and opens alerts" - Alerts Closing alerts "before each" hook for "Closes and opens alerts" #83773

Closed

Failing test: "before each" hook for "Deletes one rule" - Custom detection rules deletion and edition Deletion "before each" hook for "Deletes one rule" #83772

Closed

Failing test: "before each" hook for "Investigate alert in default timeline" - Alerts timeline "before each" hook for "Investigate alert in default timeline" #83771

Closed

Failing tests: Alert Detection Rules Custom and Export #83769

Closed

Failing test: Deletes one rule - Custom detection rules deletion and edition Deletion Deletes one rule #83740

Closed

Failing test: Deletes more than one rule - Custom detection rules deletion and edition Deletion Deletes more than one rule #83741

Closed

Failing test: Allows a rule to be edited - Custom detection rules deletion and edition Edition Allows a rule to be edited #83742

Closed

Failing test: Configures a new connector - Cases connectors Configures a new connector #65278

Closed

This was referenced Dec 9, 2020

Failing test: "before each" hook for "Does not allow to delete one rule when more than one is selected" - Deleting prebuilt rules "before each" hook for "Does not allow to delete one rule when more than one is selected" #68607

Closed

Failing test: "before all" hook for "removes the message field from the timeline when the user un-checks the field" - Fields Browser Editing the timeline "before all" hook for "removes the message field from the timeline when the user un-checks the field" #65497

Closed

Failing test: Exports a custom rule - Export rules Exports a custom rule #69849

Closed

Failing test: Mark one alert in progress when more than one open alerts are selected - Alerts Marking alerts as in-progress Mark one alert in progress when more than one open alerts are selected #78557

Closed

Failing test: Creates and activates a new EQL rule with a sequence - Detection rules, EQL Creates and activates a new EQL rule with a sequence #79522

Closed

Failing test: Creates and activates a new ml rule - Detection rules, machine learning Creates and activates a new ml rule #80569

Closed

Failing test: Host stats render with correct values - Overview Page Host stats render with correct values #82759

Closed

MadameSheema added a commit that referenced this pull request


          [7.x] fixes and unskips failing test (#85235) (#85278)

205bf8f

* fixes and unskips failing test (#85235)

* fixes the code

kibanamachine added the backport missing label

Contributor

kibanamachine commented Dec 10, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

7 similar comments

Contributor

kibanamachine commented Dec 11, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 14, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 15, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 16, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 17, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 18, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Dec 21, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 85235 or prevent reminders by adding the backport:skip label.

MadameSheema added backport:skip and removed backport missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team:Detections and Resp Team: SecuritySolution v7.11.0 v8.0.0