-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geo containment and geo threshold to gold license #85222
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc5dc15.
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
Feature:Alerting
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
labels
Dec 8, 2020
Pinging @elastic/kibana-gis (Team:Geo) |
💔 Build Failed
Failed CI StepsTest FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts.Uptime app with generated data Observer location displays less monitor availabilityStandard Out
Stack Trace
Metrics [docs]Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
Feature:Alerting
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds geo containment and threshold alert types to gold+ license levels.
With basic license:
Upgraded license to gold:
Downgraded back to basic:
@YulNaumenko I was actually unable to conditionally register the alerts on the server side. See this commit which I later reverted. Since alerts are task definitions, the task manager won't allow registration of task defitions after setup, meaning we can't make alert definitions license-dependent on the server-side. We should determine if this is ok or if there's another way to accomplish this.