Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add machine learning pages to doc_links_service.ts #85181

Merged
merged 2 commits into from
Dec 8, 2020
Merged

[ML] Add machine learning pages to doc_links_service.ts #85181

merged 2 commits into from
Dec 8, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 7, 2020

Summary

This PR adds common machine learning pages to the doc_links_service.ts

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 46930 47690 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 547.7KB 548.1KB +478.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review December 8, 2020 06:30
@lcawl lcawl requested a review from a team as a code owner December 8, 2020 06:30
@lcawl lcawl added :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Dec 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl requested a review from peteharverson December 8, 2020 06:31
@peteharverson peteharverson changed the title Add machine learning pages to doc_links_service.ts [ML] Add machine learning pages to doc_links_service.ts Dec 8, 2020
peteharverson
peteharverson approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 7ab5b03 into elastic:master Dec 8, 2020
@lcawl lcawl deleted the ml-doc-links branch December 8, 2020 17:15
lcawl added a commit to lcawl/kibana that referenced this pull request Dec 8, 2020
@lcawl
[ML] Add machine learning pages to doc_links_service.ts (elastic#85181)
0104721
@lcawl lcawl mentioned this pull request Dec 8, 2020
Merged
lcawl added a commit that referenced this pull request Dec 8, 2020
@lcawl
[ML] Add machine learning pages to doc_links_service.ts (#85181) (#85316
039ffbc 
)
@lcawl lcawl added the v7.11.0 label Dec 9, 2020
This was referenced Dec 9, 2020
Merged
Merged
@lcawl lcawl mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @kibanamachine @elasticmachine @pgayvallet @peteharverson