[Functional][TSVB] Wait for markdown textarea to be cleaned #85128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
stratoula
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
added
the
release_note:skip
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Dec 9, 2020
…85128) * [TSVB] Wait for markdown textarea to be cleaned * No need for retry
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Dec 9, 2020
…85128) * [TSVB] Wait for markdown textarea to be cleaned * No need for retry
stratoula
added a commit
that referenced
this pull request
Dec 9, 2020
stratoula
added a commit
that referenced
this pull request
Dec 9, 2020
…85371) * [TSVB] Wait for markdown textarea to be cleaned * No need for retry Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 9, 2020
…k-field-to-hot-phase * 'master' of github.com:elastic/kibana: (429 commits) simplify popover open state logic (elastic#85379) [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648) [Search Source] Do not pick scripted fields if * provided (elastic#85133) [Search] Session SO polling (elastic#84225) [Transform] Replace legacy elasticsearch client (elastic#84932) [Uptime]Refactor header and action menu (elastic#83779) Fix agg select external link (elastic#85380) [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292) clear using keyboard (elastic#85042) [GS] add tag and dashboard suggestion results (elastic#85144) [ML] API integration tests - skip GetAnomaliesTableData Add ECS field for event.code. (elastic#85109) [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) Bump highlight.js to v9.18.5 (elastic#84296) Add `server.publicBaseUrl` config (elastic#85075) [Alerting & Actions ] More debug logging (elastic#85149) [Security Solution][Case] Manual attach alert to a case (elastic#82996) Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts # x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84991
First of all, it is good to mention that this test doesn't fail a lot since we merged this PR on 7.10.
From the screenshot below I can understand that the previous result hasn't cleaned up, (The
Sep 22, 2015 @ 06:00:00.000,6 1442901600000,6belongs to the previous test) while the markdown text area has correctly the value that we want to be computed.What I have done is to let the tests to continue only when the markdown text is completely cleaned up. I think this is for sure the correct way as until now we didn't know if the text was correctly deleted, and now we can be sure that the new markdown will be computed only when the textarea is empty. I think that this will resolve the flakiness or if not it is a good point to start investigating.
Cloud runners:
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/178/
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/177/
Regular test runner:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1041/
Checklist
Delete any items that are not applicable to this PR.