[Reporting] Bump puppeteer 5.4.1 + roll chromium rev #85066
Conversation
joelgriffith
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
| @@ -19,6 +19,9 @@ | |||
| "number": 8467, | |||
| "sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9" | |||
| }, | |||
| "config": { | |||
There was a problem hiding this comment.
Needed so puppeteer doesn't auto-download it's own copy of chromium (we take care of that)
| @@ -158,7 +158,7 @@ export class HeadlessChromiumDriver { | |||
| ): Promise<ElementHandle<Element>> { | |||
| const { timeout } = opts; | |||
| logger.debug(`waitForSelector ${selector}`); | |||
| const resp = await this.page.waitFor(selector, { timeout }); // override default 30000ms | |||
| const resp = await this.page.waitForSelector(selector, { timeout }); // override default 30000ms | |||
There was a problem hiding this comment.
waitFor is now deprecated in favor of the downstream calls it makes (it's a simple higher-order fn)
| archiveChecksum: '020303e829745fd332ae9b39442ce570', | ||
| binaryChecksum: '5cdec11d45a0eddf782bed9b9f10319f', | ||
| binaryRelativePath: 'headless_shell-darwin/headless_shell', | ||
| archiveFilename: 'chromium-ef768c9-darwin_x64.zip', |
There was a problem hiding this comment.
The architecture of the platform is now added to the filename since we've introduced arm64, and this is the first full update since we've done so
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
* Update puppeteer + new headless shell bin * Bump types for pptr * Fix broken mock for pptr Co-authored-by: Kibana Machine <[email protected]>
Removes our small "type-wrapper" in favor of vanilla puppeteer and bumps chromium. I've also gone ahead and move the
page.waitForfunction to their lower-level calls since it's now deprecated.I've personally tested on the big 3!
QA
Please ensure that we test on all the relevant OSes. There's no behavioral changes here, simply a new version of Chrome on all platforms (including ARM).