Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix schema errors button #84842

Merged
merged 3 commits into from
Dec 3, 2020
Merged

[Enterprise Search] Fix schema errors button #84842

merged 3 commits into from
Dec 3, 2020

Conversation

scottybollinger
Copy link
Contributor

Summary

When migrated, the button was wrapping the link and it should be the other way around. This caused a blue link color.

Before
before

After
after

@scottybollinger
Fix schema errors button
4457637 
When migrated, the button was wrapping the link and it should be the other way around. This caused a blue link color.
@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 2, 2020
@scottybollinger scottybollinger requested a review from a team December 2, 2020 22:23
@scottybollinger scottybollinger changed the title Fix schema errors button [Enterprise Search] Fix schema errors button Dec 2, 2020
cee-chen
cee-chen reviewed Dec 2, 2020
View reviewed changes
...gins/enterprise_search/public/applications/shared/indexing_status/indexing_status_errors.tsx Outdated
Comment on lines 28 to 32
<EuiLinkTo to={viewLinkPath}>
<EuiButton color="danger" fill size="s" data-test-subj="ViewErrorsButton">
{INDEXING_STATUS_HAS_ERRORS_BUTTON}
</EuiButton>
</EuiLinkTo>
Copy link
Contributor

@cee-chen cee-chen Dec 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you can just shortcut this wrapping altogether and use EuiButtonTo!! 🎉

Suggested change
<EuiLinkTo to={viewLinkPath}>
<EuiButton color="danger" fill size="s" data-test-subj="ViewErrorsButton">
{INDEXING_STATUS_HAS_ERRORS_BUTTON}
</EuiButton>
</EuiLinkTo>
<EuiButtonTo to={viewLinkPath} color="danger" fill size="s" data-test-subj="ViewErrorsButton">
{INDEXING_STATUS_HAS_ERRORS_BUTTON}
</EuiButtonTo>

(not quite sure if the char width there is correct, you might have to make this change in-IDE so Prettier doesn't complain)

cee-chen
cee-chen approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 9cbf971 into elastic:master Dec 3, 2020
@scottybollinger scottybollinger deleted the scottybollinger/fix-schema-errors-button branch December 3, 2020 03:20
@scottybollinger scottybollinger mentioned this pull request Dec 3, 2020
Merged
scottybollinger added a commit to scottybollinger/kibana that referenced this pull request Dec 3, 2020
@scottybollinger
[Enterprise Search] Fix schema errors button (elastic#84842)
2de9cc8 
* Fix schema errors button

When migrated, the button was wrapping the link and it should be the other way around. This caused a blue link color.

* Remove redundant true value

* TIL EuiButtonTo
scottybollinger added a commit that referenced this pull request Dec 3, 2020
@scottybollinger
[Enterprise Search] Fix schema errors button (#84842) (#84856)
8096c61 
* Fix schema errors button

When migrated, the button was wrapping the link and it should be the other way around. This caused a blue link color.

* Remove redundant true value

* TIL EuiButtonTo
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/force-schedule
ffcc5ca 
* master: (40 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/flaky-event-log-tests
5cce0f7 
* master: (236 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerts/custom-rec…
7762864 
…overy-action-group

* upstream/master: (48 commits)
  [Lens] accessibility screen reader issues (elastic#84395)
  [Logs UI] Fetch single log entries via a search strategy (elastic#81710)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @cee-chen