Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visualizations] get index pattern via service instead of saved object #84458

Merged
merged 5 commits into from
Nov 30, 2020
Merged

[visualizations] get index pattern via service instead of saved object #84458

merged 5 commits into from
Nov 30, 2020

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Nov 28, 2020 •
edited
Loading

#82223 - stopped caching fields in the index pattern field list.

Use index pattern service and load index pattern instance instead of getting saved object and transforming into index pattern like object.

@mattkime mattkime requested a review from a team November 28, 2020 18:08
@mattkime mattkime requested a review from a team as a code owner November 28, 2020 18:08
@mattkime mattkime marked this pull request as draft November 28, 2020 18:08
@mattkime mattkime changed the title Embeddable get index pattern via service [visualizations] get index pattern via service instead of saved object Nov 29, 2020
@mattkime mattkime added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v8.0.0 v7.11.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServices release_note:skip Skip the PR/issue when compiling release notes labels Nov 29, 2020
@mattkime mattkime mentioned this pull request Nov 29, 2020
Closed
8 tasks
@mattkime mattkime marked this pull request as ready for review November 29, 2020 03:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

ppisljar
ppisljar approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@ppisljar ppisljar mentioned this pull request Nov 30, 2020
Merged
stratoula
stratoula approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested it locally and works as expected

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit e97aa52 into elastic:master Nov 30, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 2, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84458 or prevent reminders by adding the backport:skip label.

@mattkime mattkime mentioned this pull request Dec 2, 2020
Merged
mattkime added a commit to mattkime/kibana that referenced this pull request Dec 2, 2020
@mattkime
[visualizations] get index pattern via service instead of saved object (
b0f9812 
elastic#84458)

* embeddable - get index pattern via service instead of saved object
mattkime added a commit that referenced this pull request Dec 2, 2020
@mattkime
[visualizations] get index pattern via service instead of saved object (
261aa20 
#84458) (#84832)

* embeddable - get index pattern via service instead of saved object
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @elasticmachine @kibanamachine @ppisljar @stratoula