Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (#83628) #84250

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

alexwizp
Copy link
Contributor

Backports the following commits to 7.x:

…s for auto instead of a default 100 buckets (elastic#83628)

* TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets

Closes: elastic#54012

* remove calculate_auto

* max bars -> Level of detail

* rename allowLevelofDetail

* fix PR comment

* Update constants.ts

* Update src/plugins/vis_type_timeseries/public/application/components/index_pattern.js

Co-authored-by: Wylie Conlon <[email protected]>

* create LEVEL_OF_DETAIL_MIN_BUCKETS constant

* calcAutoIntervalLessThan -> search.aggs.calcAutoIntervalLessThan

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
# Conflicts:
#	src/plugins/data/server/server.api.md
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.8MB 1.8MB +3.6KB

Distributable file count

id before after diff
default 43392 43391 -1
oss 22876 22875 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 976.9KB 978.3KB +1.4KB
visTypeTimeseries 137.2KB 137.9KB +698.0B
total +2.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 8e0b99a into elastic:7.x Nov 25, 2020
@alexwizp alexwizp deleted the backport/7.x/pr-83628 branch January 16, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants