[APM] Elastic chart issues #84238
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,28 +5,35 @@ | |
| */ | ||
|
|
||
| import { | ||
| AnnotationDomainTypes, | ||
| AreaSeries, | ||
| Axis, | ||
| Chart, | ||
| CurveType, | ||
| LegendItemListener, | ||
| LineAnnotation, | ||
| LineSeries, | ||
| niceTimeFormatter, | ||
| Placement, | ||
| Position, | ||
| ScaleType, | ||
| Settings, | ||
| YDomainRange, | ||
| } from '@elastic/charts'; | ||
| import { EuiIcon } from '@elastic/eui'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import moment from 'moment'; | ||
| import React, { useEffect } from 'react'; | ||
| import { useHistory } from 'react-router-dom'; | ||
| import { useChartTheme } from '../../../../../observability/public'; | ||
| import { asAbsoluteDateTime } from '../../../../common/utils/formatters'; | ||
| import { TimeSeries } from '../../../../typings/timeseries'; | ||
| import { FETCH_STATUS } from '../../../hooks/useFetcher'; | ||
| import { useTheme } from '../../../hooks/useTheme'; | ||
| import { useUrlParams } from '../../../hooks/useUrlParams'; | ||
| import { useAnnotations } from '../../../hooks/use_annotations'; | ||
| import { useChartsSync } from '../../../hooks/use_charts_sync'; | ||
| import { unit } from '../../../style/variables'; | ||
| import { ChartContainer } from './chart_container'; | ||
| import { onBrushEnd } from './helper/helper'; | ||
|
|
||
|
|
@@ -45,6 +52,7 @@ interface Props { | |
| */ | ||
| yTickFormat?: (y: number) => string; | ||
| showAnnotations?: boolean; | ||
| yDomain?: YDomainRange; | ||
| } | ||
|
|
||
| export function TimeseriesChart({ | ||
|
|
@@ -56,12 +64,16 @@ export function TimeseriesChart({ | |
| yLabelFormat, | ||
| yTickFormat, | ||
| showAnnotations = true, | ||
| yDomain, | ||
| }: Props) { | ||
| const history = useHistory(); | ||
| const chartRef = React.createRef<Chart>(); | ||
| const { event, setEvent } = useChartsSync(); | ||
| const { annotations } = useAnnotations(); | ||
| const chartTheme = useChartTheme(); | ||
| const { urlParams } = useUrlParams(); | ||
| const theme = useTheme(); | ||
|
|
||
| const { start, end } = urlParams; | ||
|
|
||
| useEffect(() => { | ||
|
|
@@ -83,6 +95,8 @@ export function TimeseriesChart({ | |
| y === null || y === undefined | ||
| ); | ||
|
|
||
| const annotationColor = theme.eui.euiColorSecondary; | ||
|
|
||
| return ( | ||
| <ChartContainer hasData={!isEmpty} height={height} status={fetchStatus}> | ||
| <Chart ref={chartRef} id={id}> | ||
|
|
@@ -110,17 +124,35 @@ export function TimeseriesChart({ | |
| position={Position.Bottom} | ||
| showOverlappingTicks | ||
| tickFormat={xFormatter} | ||
| gridLine={{ visible: false }} | ||
| /> | ||
| <Axis | ||
| domain={yDomain} | ||
| id="y-axis" | ||
| ticks={3} | ||
| position={Position.Left} | ||
| tickFormat={yTickFormat ? yTickFormat : yLabelFormat} | ||
| labelFormat={yLabelFormat} | ||
| /> | ||
|
|
||
| {showAnnotations && ( | ||
| <LineAnnotation | ||
| id="annotations" | ||
| domainType={AnnotationDomainTypes.XDomain} | ||
| dataValues={annotations.map((annotation) => ({ | ||
| dataValue: annotation['@timestamp'], | ||
| header: asAbsoluteDateTime(annotation['@timestamp']), | ||
| details: `${i18n.translate('xpack.apm.chart.annotation.version', { | ||
| defaultMessage: 'Version', | ||
| })} ${annotation.text}`, | ||
| }))} | ||
| style={{ | ||
| line: { strokeWidth: 1, stroke: annotationColor, opacity: 1 }, | ||
| }} | ||
| marker={<EuiIcon type="dot" color={annotationColor} />} | ||
| markerPosition={Position.Top} | ||
| /> | ||
|
There was a problem hiding this comment. Any reason for this duplication? Wasn't it better to have it in a separate There was a problem hiding this comment.
Having it as a separate component is the reason the chart disappears after the annotations is rendered. It is a workaround until this issue gets fixed elastic/elastic-charts#914 |
||
| )} | ||
|
|
||
| {timeseries.map((serie) => { | ||
| const Series = serie.type === 'area' ? AreaSeries : LineSeries; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showGridLinesis deprecated, changing all to use gridLine.