[Ingest Manager] UI to configure agent log level #84112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
reviewed
Nov 23, 2020
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Outdated
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Outdated
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Outdated
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Outdated
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/select_log_level.tsx
Outdated
Show resolved
Hide resolved
12 tasks
…-to-configure-log-level
nchaulet
force-pushed
the
feature-allow-to-configure-log-level
branch
from
63c3ad3 to
493381e
Compare
jen-huang
approved these changes
Nov 23, 2020
| setAgentLogLevel(selectedLogLevel); | ||
| notifications.toasts.addSuccess( | ||
| i18n.translate('xpack.fleet.agentLogs.selectLogLevel.successText', { | ||
| defaultMessage: 'Changed agent logging level to "{logLevel}".', |
There was a problem hiding this comment.
I think our copywriting convention would dictate single quotes and no period here
Suggested change
| defaultMessage: 'Changed agent logging level to "{logLevel}".', | |
| defaultMessage: `Updated agent logging level to '{logLevel}'`, |
cc @gchaps
There was a problem hiding this comment.
All of our other quoted text use single quote I will do the change
There was a problem hiding this comment.
Yes, the guideline is to use single quotes.
| ); | ||
| } catch (error) { | ||
| notifications.toasts.addError(error, { | ||
| title: 'Error', |
There was a problem hiding this comment.
should be translated and given additional context, like Error updating agent logging level
cc @gchaps
There was a problem hiding this comment.
Also could be "Cannot update agent logging level"
Can
jen-huang
approved these changes
Nov 23, 2020
| indexPattern: { | ||
| title: AGENT_LOG_INDEX_PATTERN, | ||
| fields: [LOG_LEVEL_FIELD], | ||
| }, | ||
| field: LOG_LEVEL_FIELD, | ||
| query: '', | ||
| }); | ||
| setLevelValues(values.sort()); | ||
| setLevelValues([...new Set([...LEVEL_VALUES, ...values.sort()])]); |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Nov 24, 2020
nchaulet
added a commit
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on elastic/beats#22690
Allow to configure the agent log level from the UI.
If the agent version is smaller than 7.11 the feature is not available and will not be displayed.
It's not possible to change the log level to the current agent log level.
UI Change
Display the log level in the agent details
Allow to select log level