-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: tagcloud explicitly pass params #84107
Conversation
@lukeelmers @ppisljar would be great if someone of you could give more detailed explanation of why a common set of |
in order to make functions more semantic/usable we want all the arguments there explicitly. Typing json in as argument is not very nice (think about canvas). we only converted metric and tagcloud as example, and all the others will be converted by App team |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only; but updates LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it locally on Safari
Summary
Fixes #83876
The regression was caused by #77910,
more detailed explanation of the regression described here
Explicitly pass each tagcloud expression param to avoid passing extra one from
params
of saved object.Checklist
Delete any items that are not applicable to this PR.
For maintainers