Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Prettier v2.2 #83899

Merged
merged 6 commits into from
Nov 23, 2020
Merged

[DX] Prettier v2.2 #83899

merged 6 commits into from
Nov 23, 2020

Conversation

mshustov
Copy link
Contributor

Summary

Bump prettier to version v2.2 with TS v4.1 support

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Dependencies v7.11.0 labels Nov 20, 2020
@mshustov mshustov requested review from a team as code owners November 20, 2020 10:14
@mshustov mshustov requested a review from a team November 20, 2020 10:14
@mshustov mshustov requested review from a team as code owners November 20, 2020 10:14
@mshustov mshustov requested a review from a team November 20, 2020 10:14
@mshustov mshustov requested review from a team as code owners November 20, 2020 10:14
@mshustov mshustov requested a review from a team November 20, 2020 10:14
@mshustov mshustov requested a review from a team as a code owner November 20, 2020 10:14
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 20, 2020
stratoula
stratoula approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana App team changes LGTM

watson
watson approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-securty changes LGTM 👍

peteharverson
peteharverson approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML and Transforms plugins edits LGTM

@mshustov
Copy link
Contributor Author

@elastic/kibana-operations please, note that eslint task is green with 2 log messages:

The prop value with an expression type of ChainExpression could not be resolved. Please file issue to get this fixed immediately.
The prop value with an expression type of ChainExpression could not be resolved. Please file issue to get this fixed immediately.

There are no additional info, so it's unclear on what file prettier emits them.

mikecote
mikecote approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting team code changes LGTM

nreese
nreese approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review

afharo
afharo approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM!

nchaulet
nchaulet approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest Management change 🚀

joelgriffith
joelgriffith approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

cjcenizal
cjcenizal approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM. The results certainly are prettier!

afgomez
afgomez approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 95861a0 into elastic:master Nov 23, 2020
@mshustov mshustov deleted the prettier-2-2 branch November 23, 2020 12:17
@mshustov mshustov mentioned this pull request Nov 23, 2020
Closed
mshustov added a commit to mshustov/kibana that referenced this pull request Nov 23, 2020
@mshustov
[DX] Prettier v2.2 (elastic#83899)
4625e3d 
* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
# Conflicts:
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx
#	x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts
@mshustov mshustov mentioned this pull request Nov 23, 2020
Merged
clintandrewhall
clintandrewhall reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mshustov added a commit that referenced this pull request Nov 23, 2020
@mshustov
[7.x] [DX] Prettier v2.2 (#83899) (#84114)
de6090c 
* [DX] Prettier v2.2 (#83899)

* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
# Conflicts:
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx
#	x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts

* fix add removed property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall left review comments

@mikecote mikecote mikecote approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@chrisronline chrisronline chrisronline approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@peteharverson peteharverson peteharverson approved these changes

@joelgriffith joelgriffith joelgriffith approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@streamich streamich streamich approved these changes

@nchaulet nchaulet nchaulet approved these changes

@afharo afharo afharo approved these changes

@afgomez afgomez afgomez approved these changes

@nreese nreese nreese approved these changes

@stratoula stratoula stratoula approved these changes

@watson watson watson approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
backported chore Feature:Dependencies Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.