Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Remove jQuery dependency from plugins #83809

Merged
merged 5 commits into from
Nov 25, 2020
Merged

[TSVB] Remove jQuery dependency from plugins #83809

merged 5 commits into from
Nov 25, 2020

Conversation

VladLasitsa
Copy link
Contributor

Part of: #83617

Summary

Use RxJS instead of jQuery for trigger/handle cursor event.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa requested a review from alexwizp November 19, 2020 15:13
@VladLasitsa VladLasitsa changed the title [Timelion, TSVB] Remove jQuery dependency from plugins [TSVB] Remove jQuery dependency from plugins Nov 19, 2020
@alexwizp alexwizp requested a review from sulemanof November 20, 2020 12:19
sulemanof
sulemanof approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VladLasitsa VladLasitsa added Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0 labels Nov 24, 2020
@VladLasitsa VladLasitsa marked this pull request as ready for review November 24, 2020 13:07
@VladLasitsa VladLasitsa requested a review from a team November 24, 2020 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.8MB 1.8MB -155.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 137.1KB 137.0KB -66.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally, works as it should 🙂

@VladLasitsa VladLasitsa merged commit 80dfd91 into elastic:master Nov 25, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Nov 25, 2020
@VladLasitsa @kibanamachine
[TSVB] Remove jQuery dependency from plugins (elastic#83809)
2d2021c 
* Use rxjs instead of jquery for eventBus.

* Fix comments

* Removed one check because property is private.

* Resolve comments

Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa VladLasitsa mentioned this pull request Nov 25, 2020
Merged
VladLasitsa added a commit that referenced this pull request Nov 26, 2020
@VladLasitsa @kibanamachine
[TSVB] Remove jQuery dependency from plugins (#83809) (#84302)
3fb9da3 
* Use rxjs instead of jquery for eventBus.

* Fix comments

* Removed one check because property is private.

* Resolve comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@alexwizp alexwizp alexwizp approved these changes

@sulemanof sulemanof sulemanof approved these changes

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VladLasitsa @elasticmachine @kibanamachine @stratoula @alexwizp @sulemanof