Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Alerting] Add alert.updatedAt field to represent date of last user edit (#83578) #83720

Merged
merged 1 commit into from
Nov 18, 2020
Merged

[7.x] [Alerting] Add alert.updatedAt field to represent date of last user edit (#83578) #83720

merged 1 commit into from
Nov 18, 2020

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Nov 18, 2020

Backports the following commits to 7.x:

@ymao1
[Alerting] Add alert.updatedAt field to represent date of last user…
fff09dd 
… edit (elastic#83578)

* Adding alert.updatedAt field that only updates on user edit

* Updating unit tests

* Functional tests

* Updating alert attributes excluded from AAD

* Fixing test

* PR comments
@ymao1 ymao1 added the backport label Nov 18, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
alert 30 31 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit 7f2944b into elastic:7.x Nov 18, 2020
ymao1 added a commit that referenced this pull request Nov 19, 2020
@ymao1
Revert "[Alerting] Add alert.updatedAt field to represent date of l…
8a8e24b 
…ast user edit (#83578) (#83720)"

This reverts commit 7f2944b.
@ymao1 ymao1 deleted the backport/7.x/pr-83578 branch February 4, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymao1 @kibanamachine