Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Only look at ES for the missing data alert for now #83659

Closed
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
a496312
Only look at ES for the missing data alert for now
chrisronline Nov 18, 2020
4331211
Merge branch 'master' into monitoring/missing_data_only_es
kibanamachine Nov 18, 2020
b9d37aa
[ML] Persist URL state for Anomaly detection jobs using metric functi…
qn895 Nov 18, 2020
55c030a
Update typescript eslint to v4.8 (#83520)
mshustov Nov 18, 2020
67b496e
[Telemetry] Move Monitoring collection strategy to a collector (#82638)
afharo Nov 18, 2020
42fcda4
Bump is-my-json-valid to v2.20.5 (#83642)
watson Nov 18, 2020
91fe497
Bump jsonpointer to v4.1.0 (#83641)
watson Nov 18, 2020
fb4f5f0
Bump y18n@5 to v5.0.5 (#83644)
watson Nov 18, 2020
6200caa
Bump flat to v4.1.1 (#83647)
watson Nov 18, 2020
825837b
[APM] Improve router types (#83620)
dgieselaar Nov 18, 2020
620aade
[Workplace Search] Port Box changes from ent-search (#83675)
scottybollinger Nov 18, 2020
ca9d80d
[Workplace Search] Migrate SourceLogic from ent-search (#83593)
scottybollinger Nov 18, 2020
0614bfa
disable incremenetal build for legacy tsconfig.json (#82986)
mshustov Nov 18, 2020
e784ef1
Not resetting server log level if level is defined (#83651)
ymao1 Nov 18, 2020
10bdd2c
[Alerting] Add `alert.updatedAt` field to represent date of last user…
ymao1 Nov 18, 2020
692c0a2
Fixed console error, which appears when saving changes in Edit Alert …
YulNaumenko Nov 18, 2020
9f681a2
fix(NA): search examples kibana version declaration (#83182)
mistic Nov 18, 2020
380a38f
[Maps] Add query bar inputs to geo threshold alerts tracked points & …
Nov 18, 2020
7ab57d6
Add Managed label to data streams and a view switch for the table (#8…
yuliacech Nov 18, 2020
cd07732
Updating code-owners to use new core/app-services team names (#83731)
kobelb Nov 18, 2020
0dfb2c4
[Maps] Add 'crossed' & 'exited' events to tracking alert (#82463)
Nov 18, 2020
6f9540f
[Enterprise Search] Rename React Router helpers (#83718)
constancecchen Nov 18, 2020
f1a1cfa
[Workplace Search] Update SourceIcon to match latest changes in ent-s…
scottybollinger Nov 18, 2020
75f15a8
[App Search] Engine overview layout stub (#83504)
constancecchen Nov 18, 2020
6a0f5c1
chore(NA): update lmdb store to v0.8.15 (#83726)
mistic Nov 19, 2020
d6818e6
[Metrics UI] Optimizations for Snapshot and Inventory Metadata (#83596)
simianhacker Nov 19, 2020
560323f
Adding documentation for global action configuration options (#83557)
bmcconaghy Nov 19, 2020
c366228
Revert "[App Search] Engine overview layout stub (#83504)"
spalger Nov 19, 2020
1bac109
[maps] convert VectorStyleEditor to TS (#83582)
nreese Nov 19, 2020
f235f19
[data.search] Server-side background session service (#81099)
lukasolson Nov 19, 2020
d95a337
Increase bulk request timeout during esArchiver load (#83657)
pheyos Nov 19, 2020
8671e20
Skip failing cypress test
Nov 19, 2020
6bfe02a
Make expectSnapshot available in all functional test runs (#82932)
dgieselaar Nov 19, 2020
b8587d7
[Security Solution][Detections] Fix adding an action to detection rul…
cnasikas Nov 19, 2020
fb33340
Revert "[Alerting] Add `alert.updatedAt` field to represent date of l…
ymao1 Nov 19, 2020
3fabeb2
Forward any registry cache-control header for files (#83680)
Nov 19, 2020
b704035
fixed pagination in connectors list (#83638)
gmmorris Nov 19, 2020
ca6ffe3
[Fleet] Rename ingestManager plugin ID fleet (#83200)
nchaulet Nov 19, 2020
98a2ee4
[index patterns] improve index pattern cache (#83368)
mattkime Nov 19, 2020
0df746d
[Task Manager] Ensures retries are inferred from the schedule of recu…
gmmorris Nov 19, 2020
355c43c
skip flaky suite (#83793)
mistic Nov 19, 2020
f9fcc57
skip flaky suite (#65278)
mistic Nov 19, 2020
e291126
skip flaky suite (#83771)
mistic Nov 19, 2020
8b92009
skip flaky suite (#83773)
mistic Nov 19, 2020
24254d3
Improve snapshot error messages (#83785)
dgieselaar Nov 19, 2020
c0a0a0b
[Data Table] Remove extra column in split mode (#83193)
Nov 19, 2020
73ba1c9
test just part of the message to avoid updates (#83703)
Nov 19, 2020
37e58ec
[ML] Space management UI (#83320)
jgowdyelastic Nov 19, 2020
f4a956b
[DOCS] Consolidates plugins (#83712)
KOTungseth Nov 19, 2020
d6cd489
Disable exporting/importing of templates. Optimize pitch images a bi…
Nov 19, 2020
7ca801b
[Enterprise Search] Engine overview layout stub (#83756)
constancecchen Nov 19, 2020
f2bd570
[DOCS] Reallocates limitations to point-of-use (#79582)
KOTungseth Nov 19, 2020
d089de4
skip flaky suite (#79389)
mistic Nov 19, 2020
11c306f
[alerts] adds action group and date to mustache template variables fo…
pmuellr Nov 19, 2020
c490814
skip "Dashboards linked by a drilldown are both copied to a space" (#…
jbudz Nov 19, 2020
da979be
Fix small issue with detecting missing monitoring data from APM (#83646)
chrisronline Nov 19, 2020
93e2a19
PR feedback
chrisronline Nov 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ describe('MissingMonitoringDataAlert', () => {
// @ts-ignore
params: alert.defaultParams,
} as any);
const count = 2;
const count = 1;
expect(replaceState).toHaveBeenCalledWith({
alertStates: [
{
Expand Down Expand Up @@ -195,53 +195,25 @@ describe('MissingMonitoringDataAlert', () => {
stackProductName: 'kibanaInstance1',
stackProductUuid: 'kibanaUuid1',
ui: {
isFiring: true,
message: {
text:
'For the past an hour, we have not detected any monitoring data from the Kibana instance: kibanaInstance1, starting at #absolute',
nextSteps: [
{
text: '#start_linkView all Kibana instances#end_link',
tokens: [
{
startToken: '#start_link',
endToken: '#end_link',
type: 'link',
url: 'kibana/instances',
},
],
},
{
text: 'Verify monitoring settings on the instance',
},
],
tokens: [
{
startToken: '#absolute',
type: 'time',
isAbsolute: true,
isRelative: false,
timestamp: 1,
},
],
},
isFiring: false,
message: null,
severity: 'danger',
resolvedMS: 0,
triggeredMS: 1,
triggeredMS: 0,
lastCheckedMS: 0,
},
},
],
});
expect(scheduleActions).toHaveBeenCalledWith('default', {
internalFullMessage: `We have not detected any monitoring data for 2 stack product(s) in cluster: testCluster. [View what monitoring data we do have for these stack products.](http://localhost:5601/app/monitoring#/overview?_g=(cluster_uuid:abc123))`,
internalShortMessage: `We have not detected any monitoring data for 2 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
internalFullMessage: `We have not detected any monitoring data for 1 stack product(s) in cluster: testCluster. [View what monitoring data we do have for these stack products.](http://localhost:5601/app/monitoring#/overview?_g=(cluster_uuid:abc123))`,
internalShortMessage: `We have not detected any monitoring data for 1 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
action: `[View what monitoring data we do have for these stack products.](http://localhost:5601/app/monitoring#/overview?_g=(cluster_uuid:abc123))`,
actionPlain:
'Verify these stack products are up and running, then double check the monitoring settings.',
clusterName,
count,
stackProducts: 'Elasticsearch node: esName1, Kibana instance: kibanaInstance1',
stackProducts: 'Elasticsearch node: esName1',
state: 'firing',
});
});
Expand Down Expand Up @@ -442,16 +414,16 @@ describe('MissingMonitoringDataAlert', () => {
// @ts-ignore
params: alert.defaultParams,
} as any);
const count = 2;
const count = 1;
expect(scheduleActions).toHaveBeenCalledWith('default', {
internalFullMessage: `We have not detected any monitoring data for 2 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
internalShortMessage: `We have not detected any monitoring data for 2 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
internalFullMessage: `We have not detected any monitoring data for 1 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
internalShortMessage: `We have not detected any monitoring data for 1 stack product(s) in cluster: testCluster. Verify these stack products are up and running, then double check the monitoring settings.`,
action: `[View what monitoring data we do have for these stack products.](http://localhost:5601/app/monitoring#/overview?_g=(cluster_uuid:abc123))`,
actionPlain:
'Verify these stack products are up and running, then double check the monitoring settings.',
clusterName,
count,
stackProducts: 'Elasticsearch node: esName1, Kibana instance: kibanaInstance1',
stackProducts: 'Elasticsearch node: esName1',
state: 'firing',
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
ALERT_MISSING_MONITORING_DATA,
INDEX_PATTERN_ELASTICSEARCH,
ALERT_DETAILS,
ELASTICSEARCH_SYSTEM_ID,
} from '../../common/constants';
import { getCcsIndexPattern } from '../lib/alerts/get_ccs_index_pattern';
import { AlertMessageTokenType, AlertSeverity } from '../../common/enums';
Expand Down Expand Up @@ -139,10 +140,14 @@ export class MissingMonitoringDataAlert extends BaseAlert {
now - limit - LIMIT_BUFFER
);
return missingData.map((missing) => {
// TODO: only Elasticsearch until we can figure out how to handle upgrades for the rest of the stack
// https://github.com/elastic/kibana/issues/83309
const shouldFire =
missing.gapDuration > duration && missing.stackProduct === ELASTICSEARCH_SYSTEM_ID;
return {
instanceKey: `${missing.clusterUuid}:${missing.stackProduct}:${missing.stackProductUuid}`,
clusterUuid: missing.clusterUuid,
shouldFire: missing.gapDuration > duration,
shouldFire,
severity: AlertSeverity.Danger,
meta: { missing, limit },
ccs: missing.ccs,
Expand Down