Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive the port from the protocol in cases where it's not explicitly in the URL #83583

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Derive the port from the protocol in cases where it's not explicitly in the URL #83583

merged 1 commit into from
Nov 18, 2020

Conversation

joelgriffith
Copy link
Contributor

Summary

Kibana can make requests to URLs like: https://feeds-staging.elastic.co/kibana/v8.0.0.json, which doesn't explicitly list its own port. This PR enhances our port/hostname/protocol check to "derive" the port from the protocol in cases where it's not explicitly listed.

@joelgriffith joelgriffith added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.10.1 labels Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@joelgriffith joelgriffith requested a review from a team November 17, 2020 20:40
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joelgriffith joelgriffith merged commit e07d6d0 into elastic:master Nov 18, 2020
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
…o-node-details

* 'master' of github.com:elastic/kibana:
  Derive the port from the protocol in cases where it's not explicitly stated (elastic#83583)
  [CI] Build docker image during packer_cache (elastic#82145)
  [esaggs][inspector]: Refactor to prep for esaggs move to server. (elastic#83199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants