Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Add logs to node details #83433

Merged
merged 20 commits into from
Nov 19, 2020
Merged

[Metrics UI] Add logs to node details #83433

merged 20 commits into from
Nov 19, 2020

Conversation

phillipb
Copy link
Contributor

Summary

Add logs tab filtered to the node id. Fixes: #80308

Screen Shot 2020-11-16 at 9 05 38 AM

Checklist

Delete any items that are not applicable to this PR.

@phillipb phillipb added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Nov 16, 2020
@phillipb phillipb requested a review from a team as a code owner November 16, 2020 15:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

kibanamachine and others added 4 commits November 16, 2020 10:07
@kibanamachine
Merge branch 'master' into add-logs-to-node-details
006f986
@phillipb
Update i18n
4dcc04f
@phillipb
Merge branch 'add-logs-to-node-details' of github.com:phillipb/kibana…
b58ece4 
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana:
  fix tall vislib charts in visualize (elastic#83340)
  [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957)
  [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401)
  fix logstash central pipeline management test  (elastic#83281)
  [Search] Send to background UI (elastic#81793)
  Migrate `/translations` route to core (elastic#83280)
  [APM] Ensure APM jest script can run (elastic#83398)
  [Uptime] Monitor status alert use url as instance (elastic#81736)
  [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259)
  TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964)
  [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139)
  Skips Vega test
  skip flaky suite (elastic#79967)
  [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020)
  Added ability to fire actions when an alert instance is resolved (elastic#82799)
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-logs-to-n…
2b1a2be 
…ode-details

* 'master' of github.com:elastic/kibana:
  Remove dependency of tests on strict SyntaxKind values (elastic#83440)
  [SecuritySolution] override timerange for prebuilt templates (elastic#82468)
  [Enterprise Search] Added a shouldShowActiveForSubroutes option (elastic#83338)
  [Lens] Make the dimension flyout panel stay close on outside click (elastic#83059)
  [Security Solution] Gracefully handle errors in detection rules install (elastic#83306)
  Fix advanced settings category sorting (elastic#83394)
@phillipb phillipb requested a review from Zacqary November 18, 2020 14:26
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

kibanamachine and others added 5 commits November 18, 2020 17:48
@kibanamachine
Merge branch 'master' into add-logs-to-node-details
627617b
@phillipb
Merge branch 'add-logs-to-node-details' of github.com:phillipb/kibana…
2249140 
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits)
  [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463)
  Updating code-owners to use new core/app-services team names (elastic#83731)
  Add Managed label to data streams and a view switch for the table (elastic#83049)
  [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871)
  fix(NA): search examples kibana version declaration (elastic#83182)
  Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610)
  [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578)
  Not resetting server log level if level is defined (elastic#83651)
  disable incremenetal build for legacy tsconfig.json (elastic#82986)
  [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593)
  [Workplace Search] Port Box changes from ent-search (elastic#83675)
  [APM] Improve router types (elastic#83620)
  Bump flat to v4.1.1 (elastic#83647)
  Bump y18n@5 to v5.0.5 (elastic#83644)
  Bump jsonpointer to v4.1.0 (elastic#83641)
  Bump is-my-json-valid to v2.20.5 (elastic#83642)
  [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638)
  Update typescript eslint to v4.8 (elastic#83520)
  [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507)
  [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216)
  ...
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-logs-to-n…
6290c27 
…ode-details

* 'master' of github.com:elastic/kibana:
  fixed pagination in connectors list (elastic#83638)
  Forward any registry cache-control header for files (elastic#83680)
  Revert "[Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578)"
  [Security Solution][Detections] Fix adding an action to detection rules (elastic#83722)
  Make expectSnapshot available in all functional test runs (elastic#82932)
  Skip failing cypress test
  Increase bulk request timeout during esArchiver load (elastic#83657)
  [data.search] Server-side background session service (elastic#81099)
  [maps] convert VectorStyleEditor to TS (elastic#83582)
  Revert "[App Search] Engine overview layout stub (elastic#83504)"
  Adding documentation for global action configuration options (elastic#83557)
  [Metrics UI] Optimizations for Snapshot and Inventory Metadata (elastic#83596)
  chore(NA): update lmdb store to v0.8.15 (elastic#83726)
  [App Search] Engine overview layout stub (elastic#83504)
  [Workplace Search] Update SourceIcon to match latest changes in ent-search (elastic#83714)
  [Enterprise Search] Rename React Router helpers (elastic#83718)
@phillipb
Fix lint
b01d290
@phillipb
Merge branch 'master' into add-logs-to-node-details
544f500
Zacqary
Zacqary approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1052 1051 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.6MB 2.6MB +4.0KB

Distributable file count

id before after diff
default 42901 42898 -3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 174.3KB 174.2KB -51.0B
Unknown metric groups

async chunk count

id before after diff
infra 14 13 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit bc49b5b into elastic:master Nov 19, 2020
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 19, 2020
@phillipb @kibanamachine @Zacqary
[Metrics UI] Add logs to node details (elastic#83433)
4bf09b5 
* Add charts to the metrics tab

* Add timepicker, i18n, polish

* Fix copyrite

* Add log stream component to node details

* Add logs tab with ability to search

* Update i18n

* Apply suggestions from code review

Co-authored-by: Zacqary Adam Xeper <[email protected]>

* Update comment

* Fix lint

* Fix eslint

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Zacqary Adam Xeper <[email protected]>
@phillipb phillipb mentioned this pull request Nov 19, 2020
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 23, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 29, 2020
phillipb added a commit that referenced this pull request Nov 29, 2020
@phillipb @kibanamachine @Zacqary
[Metrics UI] Add logs to node details (#83433) (#83868)
e970045 
* Add charts to the metrics tab

* Add timepicker, i18n, polish

* Fix copyrite

* Add log stream component to node details

* Add logs tab with ability to search

* Update i18n

* Apply suggestions from code review

Co-authored-by: Zacqary Adam Xeper <[email protected]>

* Update comment

* Fix lint

* Fix eslint

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Zacqary Adam Xeper <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Zacqary Adam Xeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Enhanced host details - Logs
4 participants
@phillipb @elasticmachine @kibanamachine @Zacqary