Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Actions] Removing placeholders and updating validation messages on connector forms (#82734) #83336

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Nov 12, 2020

Backports the following commits to 7.x:

…onnector forms (elastic#82734)

* Removing placeholders. Updating validation messages

* Splitting out url and protocol validation

* Adding url validation for slack webhook urls

* Fixing test

Co-authored-by: Kibana Machine <[email protected]>
@ymao1 ymao1 added the backport label Nov 12, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -207.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 133.3KB 135.2KB +1.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit d449d53 into elastic:7.x Nov 12, 2020
@ymao1 ymao1 deleted the backport/7.x/pr-82734 branch February 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants