Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Fix area rendering with negative values #83313

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[TSVB] Fix area rendering with negative values #83313

merged 2 commits into from
Nov 16, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Nov 12, 2020 •
edited
Loading

Summary

Updating elastic-charts to fix the wrong negative rendering area regression in TSVB

fix #82929

the original fix was done inside elastic-charts in elastic/elastic-charts#896

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:DataVis Team label for DataVis Team v7.10.1 labels Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

alexwizp
alexwizp approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

VladLasitsa
VladLasitsa approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markov00
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
[email protected] 2.4MB 2.4MB +933.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 merged commit 08fb9b6 into elastic:7.10 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:DataVis Team label for DataVis Team Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markov00 @elasticmachine @kibanamachine @VladLasitsa @nickofthyme @alexwizp