Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Move ingestManager plugin to fleet #82886

Merged
merged 12 commits into from
Nov 9, 2020

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 6, 2020

Summary

In the effort of renaming the ingestManager plugin fleet, move the plugin from ingestManager to fleet

Renaming the plugin ID will come in a following pull request ( this will rename the kibana URL => ingestManager => fleet)

Detailed renaming

x-pack/plugins/ingest_manager => x-pack/plugins/fleet
x-pack/plugins/ingest_manager/public/sections/fleet => x-pack/plugins/ingest_manager/public/sections/agents

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Nov 6, 2020
@nchaulet nchaulet self-assigned this Nov 6, 2020
@nchaulet nchaulet marked this pull request as ready for review November 6, 2020 20:32
@nchaulet nchaulet requested review from a team as code owners November 6, 2020 20:33
@nchaulet nchaulet requested a review from a team November 6, 2020 20:33
@nchaulet nchaulet requested a review from a team as a code owner November 6, 2020 20:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! Caught a few typos likely caused by bulk find/replace.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index management code LGTM

@nchaulet nchaulet requested a review from paul-tavares November 9, 2020 13:55
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reading. Will pull down & run, too.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB -302.0B

page load bundle size

id before after diff
ingestManager 386.3KB 386.2KB -99.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii self-requested a review November 9, 2020 15:45
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally and did a happy path check for a few things. LGTM 🚀

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Thanks

@nchaulet nchaulet merged commit 441a0d4 into elastic:master Nov 9, 2020
nchaulet added a commit to nchaulet/kibana that referenced this pull request Nov 9, 2020
# Conflicts:
#	.github/CODEOWNERS
#	.github/paths-labeller.yml
#	x-pack/plugins/fleet/server/services/epm/archive/cache.ts
#	x-pack/plugins/fleet/server/services/epm/registry/cache.ts
#	x-pack/plugins/ingest_manager/server/services/epm/archive/cache.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants