-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Move ingestManager plugin to fleet #82886
[Fleet] Move ingestManager plugin to fleet #82886
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping! Caught a few typos likely caused by bulk find/replace.
x-pack/plugins/index_management/public/application/app_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/index_management/public/application/mount_management_section.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index management code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after reading. Will pull down & run, too.
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out locally and did a happy path check for a few things. LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Thanks
# Conflicts: # .github/CODEOWNERS # .github/paths-labeller.yml # x-pack/plugins/fleet/server/services/epm/archive/cache.ts # x-pack/plugins/fleet/server/services/epm/registry/cache.ts # x-pack/plugins/ingest_manager/server/services/epm/archive/cache.ts
Summary
In the effort of renaming the
ingestManager
pluginfleet
, move the plugin fromingestManager
tofleet
Renaming the plugin ID will come in a following pull request ( this will rename the kibana URL => ingestManager => fleet)
Detailed renaming