Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Remove kui usage #82810

Merged
merged 5 commits into from
Nov 10, 2020
Merged

[Visualizations] Remove kui usage #82810

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dc08a3
[Visualize] Remove kui usage
stratoula Nov 6, 2020
5c23c09
Merge branch 'master' into remove-kui-visualizations
kibanamachine Nov 9, 2020
79073f2
Use EuiPromptButton istead of EuiCallout
stratoula Nov 9, 2020
f025303
Add a link to advanced settings for visualizations docs
stratoula Nov 9, 2020
df4e127
Changes requested on code review
stratoula Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/public/doc_links/doc_links_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ export class DocLinksService {
management: {
kibanaSearchSettings: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/advanced-options.html#kibana-search-settings`,
dashboardSettings: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/advanced-options.html#kibana-dashboard-settings`,
visualizationSettings: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/advanced-options.html#kibana-visualization-settings`,
},
visualize: {
guide: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/visualize.html`,
Expand Down
1 change: 0 additions & 1 deletion src/plugins/visualizations/public/embeddable/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@import 'visualize_lab_disabled';
@import 'embeddables';
13 changes: 0 additions & 13 deletions src/plugins/visualizations/public/embeddable/_visualize_lab_disabled.scss
View file
Open in desktop

This file was deleted.

48 changes: 29 additions & 19 deletions src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,39 @@
* under the License.
*/

import { FormattedMessage } from '@kbn/i18n/react';
import { FormattedMessage, I18nProvider } from '@kbn/i18n/react';
import { EuiEmptyPrompt, EuiLink } from '@elastic/eui';
import React from 'react';
import { getDocLinks } from '../services';

export function DisabledLabVisualization({ title }: { title: string }) {
const advancedSettingsLink = getDocLinks().links.management.visualizationSettings;
return (
<div className="visDisabledLabVisualization">
<div
className="kuiVerticalRhythm visDisabledLabVisualization__icon kuiIcon fa-flask"
aria-hidden="true"
<I18nProvider>
<EuiEmptyPrompt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we add a titleSize="xs" prop to EuiEmptyPrompt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed them both! Thank you 🙂
Screenshot 2020-11-09 at 5 47 44 PM

title={
<FormattedMessage
stratoula marked this conversation as resolved.
Show resolved Hide resolved
id="visualizations.disabledLabVisualizationTitle"
defaultMessage="{title} is a lab visualization."
values={{ title }}
/>
}
iconType="beaker"
body={
<FormattedMessage
id="visualizations.disabledLabVisualizationMessage"
defaultMessage="Please turn on lab-mode in the advanced settings to see lab visualizations."
/>
}
actions={
<EuiLink target="_blank" external href={advancedSettingsLink}>
<FormattedMessage
id="visualizations.disabledLabVisualizationLink"
defaultMessage="Read documentation"
/>
</EuiLink>
}
/>
<div className="kuiVerticalRhythm">
<FormattedMessage
id="visualizations.disabledLabVisualizationTitle"
defaultMessage="{title} is a lab visualization."
values={{ title: <em className="visDisabledLabVisualization__title">{title}</em> }}
/>
</div>
<div className="kuiVerticalRhythm">
<FormattedMessage
id="visualizations.disabledLabVisualizationMessage"
defaultMessage="Please turn on lab-mode in the advanced settings to see lab visualizations."
/>
</div>
</div>
</I18nProvider>
);
}