-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds cloud links to user menu #82803
Conversation
Added cloud as optional dep to security plugin Added styles for security nav control component Added cloud links to cloud config Fixed prop type Fixed TS errors
RE: feedback from #66825 (review) @legrego @pgayvallet 1c8074b should properly address your feedback and retain all registered user menu links when |
Pinging @elastic/kibana-core-ui (Team:Core UI) |
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cqliu1 thanks for taking the time to revert the previous PR to address our feedback ❤️.
Your most recent changes look good to me! My one request before approving is to add tests to cover the new functions that the security plugin is exposing as part of its public contract (addUserMenuLinks
and getUserMenuLinks$
). The existing x-pack/plugins/security/public/nav_control/nav_control_service.test.ts
would be a good place for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for cloud
plugin changes.
@legrego This is ready for another look. I've added tests for the nav control service. |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Ryan Keairns <[email protected]>
…kibana into bootstrap-node-details-overlay * 'bootstrap-node-details-overlay' of github.com:phillipb/kibana: (49 commits) [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) Fix ilm navigation (elastic#81664) ...
Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Ryan Keairns <[email protected]>
…na into alerts/stack-alerts-public * 'alerts/stack-alerts-public' of github.com:gmmorris/kibana: [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) :
Summary
Reattempt at #66825.
Closes #62863.
Related to https://github.com/elastic/cloud/issues/57695.
This converts the Kibana user menu to a context menu and adds cloud links to the user menu in the global nav. This works off of the assumption that the URLs for the additional cloud links will be configured in the
kibana.yml
.Non-cloud user
Cloud user
Notable changes
addUserMenuLinks
andgetUserMenuLinks$
to thestart
method of theSecurityNavControlService
in thesecurity
plugin to allow other plugins to add links to the user menu in the global navresetPasswordUrl
andaccountUrl
tocloud
plugin configTo test
You can mock enabling the cloud plugin locally by defining a cloud ID and providing the urls for the profile links added in this PR in your
kibana.dev.yml
, like so:Checklist
Delete any items that are not applicable to this PR.
For maintainers