[alerts] adds `defaultActionMessage` to index threshold alert UI type definition #82753

pmuellr · 2020-11-05T17:43:16Z

note: this PR is a "copy" of PR #80936, moved from the community contributor's repo into mine, and placed in a separate branch from master

The above screenshot displays the defaultActionMessage in the text box when an action is created for index threshold alert.

functional tests for index threshold default action message

…ests/alerting/builtin_alert_types/index_threshold/alert.ts

kibanamachine · 2020-11-05T19:27:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a519a6d
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/rollup/rollup·js.apis management rollup jobs Index patterns should return the date, numeric and keyword fields when an index pattern matches indices

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] moving index [ilm-history-4-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]         │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[ilm-history-4-000001][0]]])." previous.health="YELLOW" reason="shards started [[ilm-history-4-000001][0]]"
[00:00:00]         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] moving index [ilm-history-4-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] moving index [ilm-history-4-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:04:21]           └-: management
[00:04:21]             └-> "before all" hook
[00:04:36]             └-: rollup
[00:04:36]               └-> "before all" hook
[00:04:36]               └-: jobs
[00:04:36]                 └-> "before all" hook
[00:04:37]                 └-: Index patterns
[00:04:37]                   └-> "before all" hook
[00:04:37]                   └-> should return the date, numeric and keyword fields when an index pattern matches indices
[00:04:37]                     └-> "before each" hook: global before each
[00:04:37]                     │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] [lkvpsuaksigyi-1604602512925] creating index, cause [api], templates [], shards [1]/[1]
[00:04:37]                     └- ✖ fail: apis management rollup jobs Index patterns should return the date, numeric and keyword fields when an index pattern matches indices
[00:04:37]                     │       Error: expected { doesMatchIndices: true,
[00:04:37]                     │   doesMatchRollupIndices: false,
[00:04:37]                     │   dateFields: [ 'testCreatedField' ],
[00:04:37]                     │   numericFields: [ '_doc_count', 'testTotalField' ],
[00:04:37]                     │   keywordFields: [ 'testTagField' ] } to sort of equal { dateFields: [ 'testCreatedField' ],
[00:04:37]                     │   keywordFields: [ 'testTagField' ],
[00:04:37]                     │   numericFields: [ 'testTotalField' ],
[00:04:37]                     │   doesMatchIndices: true,
[00:04:37]                     │   doesMatchRollupIndices: false }
[00:04:37]                     │       + expected - actual
[00:04:37]                     │ 
[00:04:37]                     │          "keywordFields": [
[00:04:37]                     │            "testTagField"
[00:04:37]                     │          ]
[00:04:37]                     │          "numericFields": [
[00:04:37]                     │       -    "_doc_count"
[00:04:37]                     │            "testTotalField"
[00:04:37]                     │          ]
[00:04:37]                     │        }
[00:04:37]                     │       
[00:04:37]                     │       at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:37]                     │       at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:37]                     │       at Context.it (test/api_integration/apis/management/rollup/rollup.js:48:25)
[00:04:37]                     │ 
[00:04:37]                     │

Stack Trace

{ Error: expected { doesMatchIndices: true,
  doesMatchRollupIndices: false,
  dateFields: [ 'testCreatedField' ],
  numericFields: [ '_doc_count', 'testTotalField' ],
  keywordFields: [ 'testTagField' ] } to sort of equal { dateFields: [ 'testCreatedField' ],
  keywordFields: [ 'testTagField' ],
  numericFields: [ 'testTotalField' ],
  doesMatchIndices: true,
  doesMatchRollupIndices: false }
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/management/rollup/rollup.js:48:25)
  actual:
   '{\n  "dateFields": [\n    "testCreatedField"\n  ]\n  "doesMatchIndices": true\n  "doesMatchRollupIndices": false\n  "keywordFields": [\n    "testTagField"\n  ]\n  "numericFields": [\n    "_doc_count"\n    "testTotalField"\n  ]\n}',
  expected:
   '{\n  "dateFields": [\n    "testCreatedField"\n  ]\n  "doesMatchIndices": true\n  "doesMatchRollupIndices": false\n  "keywordFields": [\n    "testTagField"\n  ]\n  "numericFields": [\n    "testTotalField"\n  ]\n}',
  showDiff: true }

X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/rollup/rollup·js.apis management rollup jobs Index patterns should return the date, numeric and keyword fields when an index pattern matches indices

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:04:18]           └-: management
[00:04:18]             └-> "before all" hook
[00:04:33]             └-: rollup
[00:04:33]               └-> "before all" hook
[00:04:33]               └-: jobs
[00:04:33]                 └-> "before all" hook
[00:04:33]                 └-: Index patterns
[00:04:33]                   └-> "before all" hook
[00:04:33]                   └-> should return the date, numeric and keyword fields when an index pattern matches indices
[00:04:33]                     └-> "before each" hook: global before each
[00:04:33]                     │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1604598222355747611] [qzgsyamk-1604601262812] creating index, cause [api], templates [], shards [1]/[1]
[00:04:33]                     └- ✖ fail: apis management rollup jobs Index patterns should return the date, numeric and keyword fields when an index pattern matches indices
[00:04:33]                     │       Error: expected { doesMatchIndices: true,
[00:04:33]                     │   doesMatchRollupIndices: false,
[00:04:33]                     │   dateFields: [ 'testCreatedField' ],
[00:04:33]                     │   numericFields: [ '_doc_count', 'testTotalField' ],
[00:04:33]                     │   keywordFields: [ 'testTagField' ] } to sort of equal { dateFields: [ 'testCreatedField' ],
[00:04:33]                     │   keywordFields: [ 'testTagField' ],
[00:04:33]                     │   numericFields: [ 'testTotalField' ],
[00:04:33]                     │   doesMatchIndices: true,
[00:04:33]                     │   doesMatchRollupIndices: false }
[00:04:33]                     │       + expected - actual
[00:04:33]                     │ 
[00:04:33]                     │          "keywordFields": [
[00:04:33]                     │            "testTagField"
[00:04:33]                     │          ]
[00:04:33]                     │          "numericFields": [
[00:04:33]                     │       -    "_doc_count"
[00:04:33]                     │            "testTotalField"
[00:04:33]                     │          ]
[00:04:33]                     │        }
[00:04:33]                     │       
[00:04:33]                     │       at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:33]                     │       at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:33]                     │       at Context.it (test/api_integration/apis/management/rollup/rollup.js:48:25)
[00:04:33]                     │ 
[00:04:33]                     │

Stack Trace

{ Error: expected { doesMatchIndices: true,
  doesMatchRollupIndices: false,
  dateFields: [ 'testCreatedField' ],
  numericFields: [ '_doc_count', 'testTotalField' ],
  keywordFields: [ 'testTagField' ] } to sort of equal { dateFields: [ 'testCreatedField' ],
  keywordFields: [ 'testTagField' ],
  numericFields: [ 'testTotalField' ],
  doesMatchIndices: true,
  doesMatchRollupIndices: false }
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/management/rollup/rollup.js:48:25)
  actual:
   '{\n  "dateFields": [\n    "testCreatedField"\n  ]\n  "doesMatchIndices": true\n  "doesMatchRollupIndices": false\n  "keywordFields": [\n    "testTagField"\n  ]\n  "numericFields": [\n    "_doc_count"\n    "testTotalField"\n  ]\n}',
  expected:
   '{\n  "dateFields": [\n    "testCreatedField"\n  ]\n  "doesMatchIndices": true\n  "doesMatchRollupIndices": false\n  "keywordFields": [\n    "testTagField"\n  ]\n  "numericFields": [\n    "testTotalField"\n  ]\n}',
  showDiff: true }

Metrics [docs]

page load bundle size

id	before	after	diff
`triggersActionsUi`	131.9KB	132.3KB	+413.0B

Saved Objects .kibana field count

id	before	after	diff
`_doc_count`	-	1	+1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr · 2020-11-09T15:59:11Z

closing - I had this branch as a backup

dB2510 and others added 16 commits October 17, 2020 10:38

resolves elastic#78148

a012543

Merge branch 'master' into master

8a50c7f

required changes done for elastic#78148

c5808a0

Merge branch 'master' of https://github.com/dB2510/kibana

5d3b8be

Merge branch 'master' of https://github.com/elastic/kibana

10cf1ec

requested changes done elastic#78148

e00826b

functional tests for index threshold default action message

86c0e5b

resolved type-check and jest errors

4cc33bc

Merge branch 'master' of https://github.com/elastic/kibana

18c0da9

Merge pull request #1 from pmuellr/alerts/default-action-message-ft

7fe16cd

functional tests for index threshold default action message

Merge branch 'master' of https://github.com/elastic/kibana

9c931be

Merge branch 'master' of https://github.com/elastic/kibana

eb2b0c7

added functional UI test for defaultActionMessage

5830f13

Merge branch 'master' of https://github.com/elastic/kibana

31f50e6

added functional UI test to an existing test

ebb3fee

remove comments in x-pack/test/alerting_api_integration/spaces_only/t…

a519a6d

…ests/alerting/builtin_alert_types/index_threshold/alert.ts

pmuellr mentioned this pull request Nov 5, 2020

Added defaultActionMessage to index threshold alert UI type definition #80936

Merged

pmuellr closed this Nov 9, 2020

pmuellr added the backport:skip This commit does not require backporting label Nov 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[alerts] adds `defaultActionMessage` to index threshold alert UI type definition #82753

[alerts] adds `defaultActionMessage` to index threshold alert UI type definition #82753

pmuellr commented Nov 5, 2020

kibanamachine commented Nov 5, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

pmuellr commented Nov 9, 2020

[alerts] adds defaultActionMessage to index threshold alert UI type definition #82753

[alerts] adds defaultActionMessage to index threshold alert UI type definition #82753

Conversation

pmuellr commented Nov 5, 2020

kibanamachine commented Nov 5, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

page load bundle size

Saved Objects .kibana field count

pmuellr commented Nov 9, 2020

[alerts] adds `defaultActionMessage` to index threshold alert UI type definition #82753

[alerts] adds `defaultActionMessage` to index threshold alert UI type definition #82753