[App Search] Implement initial Engine routing/navigation #82549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
Feature:Plugins
release_note:skip
cee-chen
commented
Nov 4, 2020
Comment on lines
+12
to
+14
| export const ENGINES_TITLE = i18n.translate('xpack.enterpriseSearch.appSearch.engines.title', { | ||
| defaultMessage: 'Engines', | ||
| }); |
There was a problem hiding this comment.
This definitely probably doesn't belong in this file but I plan on moving it/DRYing out more i18n const's in a follow up PR here shortly.
There was a problem hiding this comment.
Follow up cleanup PR after this: cee-chen/kibana@engine-nav...consts-refactor
Routes: use generatePath to better match ent-search Roles: We're using "Search UI" in the nav copy now, so we should update our vars accordingly
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
that referenced
this pull request
Nov 5, 2020
…2758) * [Setup] Update routes + role privileges Routes: use generatePath to better match ent-search Roles: We're using "Search UI" in the nav copy now, so we should update our vars accordingly * Add new EngineNav and EngineRouter components * Update existing components to use new EngineRouter/EngineNav * Add App Search engine label & new SideNavItem component * Add EngineRouter breadcrumbs * [Refactor] DRY out i18n constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the engine sub-nav & routing to App Search, based on Davey's initial Figma mocks (there is some deviation and re-ordering from ent-search as a note.)
It adds two dummy "routes" (Engine Overview and Analytics), mostly to confirm that routing and breadcrumbs work. There are still a lot of TODOs in the code (mostly around EngineLogic).
I recommend following along by commit if possible.
Screencaps
Checklist