Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Updates rollup test to allow incoming doc_count field mapper #82547

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

tylersmalley
Copy link
Contributor

A doc_count field mapper was added in elastic/elasticsearch#64503

This is currently failing the ES promotion. After this promotion, we can go back and update this test to be an exact match on the body if we think that is the desired assertion.

A doc_count field mapper was added in
elastic/elasticsearch#64503

This is currently failing the ES promotion. After this promotion, we can
go back and update this test to be an exact match on the body if we
think that is the desired assertion.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley tylersmalley added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, spotted one missing assertion.

Signed-off-by: Tyler Smalley <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 286dbca into elastic:master Nov 4, 2020
cjcenizal added a commit that referenced this pull request Nov 4, 2020
…82547) (#82554)

* [test] Updates rollup test to allow incoming doc_count field mapper

A doc_count field mapper was added in
elastic/elasticsearch#64503

This is currently failing the ES promotion. After this promotion, we can
go back and update this test to be an exact match on the body if we
think that is the desired assertion.

Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Tyler Smalley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants