Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a task for each API key which should be invalidated instead of direct invalidating #82238

Conversation

YulNaumenko
Copy link
Contributor

Draft resolve for #53868

@YulNaumenko YulNaumenko self-assigned this Nov 2, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 2, 2020

💔 Build Failed

Failed CI Steps


Test Failures

X-Pack Jest Tests.x-pack/plugins/alerts/server/alerts_client/tests.update() updates given parameters

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Cannot read property 'mockResolvedValue' of undefined
    at getBeforeSetup (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/lib.ts:49:39)
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/update.test.ts:49:3)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:230:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:170:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:175:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

X-Pack Jest Tests.x-pack/plugins/alerts/server/alerts_client/tests.update() calls the createApiKey function

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Cannot read property 'mockResolvedValue' of undefined
    at getBeforeSetup (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/lib.ts:49:39)
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/update.test.ts:49:3)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:230:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:170:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:175:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

X-Pack Jest Tests.x-pack/plugins/alerts/server/alerts_client/tests.update() doesn't call the createAPIKey function when alert is disabled

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Cannot read property 'mockResolvedValue' of undefined
    at getBeforeSetup (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/lib.ts:49:39)
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/parallel/9/kibana/x-pack/plugins/alerts/server/alerts_client/tests/update.test.ts:49:3)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:230:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:170:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:175:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

and 113 more failures, only showing the first 3.

Metrics [docs]

distributable file count

id before after diff
default 48125 48126 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko linked an issue Nov 6, 2020 that may be closed by this pull request
@legrego legrego closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced API Key invalidation
3 participants