Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Add full custom metric UI to inventory alerts #81929

Merged
merged 9 commits into from
Nov 5, 2020
Merged

[Metrics UI] Add full custom metric UI to inventory alerts #81929

merged 9 commits into from
Nov 5, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 28, 2020

Summary

Closes #65761

Screen Shot 2020-10-28 at 12 47 43 PM

Custom metrics can now be created and edited from directly within the Inventory Alert UI.

Checklist

@Zacqary Zacqary added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Oct 28, 2020
@Zacqary Zacqary requested a review from a team as a code owner October 28, 2020 17:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 2, 2020

@elasticmachine merge upstream

phillipb
phillipb approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
infra 2.6MB 2.6MB +6.7KB

page load bundle size

id before after diff
infra 173.2KB 173.5KB +308.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 250fe67 into elastic:master Nov 5, 2020
@Zacqary Zacqary deleted the 65761-custom-metric-alert-ui branch November 5, 2020 18:24
This was referenced Nov 5, 2020
Merged
Closed
Zacqary added a commit to Zacqary/kibana that referenced this pull request Nov 5, 2020
@Zacqary @kibanamachine
[Metrics UI] Add full custom metric UI to inventory alerts (elastic#8…
f80bb6e 
…1929)

Co-authored-by: Kibana Machine <[email protected]>
Zacqary added a commit to Zacqary/kibana that referenced this pull request Nov 5, 2020
@Zacqary @kibanamachine
[Metrics UI] Add full custom metric UI to inventory alerts (elastic#8…
61061f3 
…1929)

Co-authored-by: Kibana Machine <[email protected]>
Zacqary added a commit that referenced this pull request Nov 5, 2020
@Zacqary @kibanamachine
[7.x] [Metrics UI] Add full custom metric UI to inventory alerts (#81929
850c0bb 
) (#82763)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@Zacqary Zacqary mentioned this pull request Jan 4, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Add custom metrics to Inventory alert
4 participants
@Zacqary @elasticmachine @kibanamachine @phillipb