[Lens] New value labels config option for bar charts #81776

dej611 · 2020-10-27T13:48:22Z

Summary

This PR contains all the logic for the new bar chart value labels feature based on previous PoC feedback.

This is a minimal set of feature, specifically scoped to address only bar charts (bar and bar_horizontal) with the following limits:

Stacked charts are not supported yet (it requires some more design and features from the charting lib)
Histogram charts (time and number) are not supported yet
No advanced positioning option (only hide/show) right now

Task todo list:

Added new switch option in the Values toolbar panel
Option set to hide by default
Preserve setting when switching between charts
Disable Values in toolbar for Histograms
Fix the formatter on horizontal bar charts
Exclude suggestion visualizations from the value labels rendering
Revisit help tooltip copy

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

dej611 · 2020-10-29T17:45:42Z

The toolbar now disables the values menu for histograms:

✅ Added tests

Open questions:

should multi layers bar charts be supported?
- It is currently enabled, but easy to disable.

should break down configurations be supported?
- It is currently enabled, but easy to disable.

elasticmachine · 2020-10-30T09:43:53Z

Pinging @elastic/kibana-app (Team:KibanaApp)

dej611 · 2020-10-30T09:44:39Z

@elasticmachine merge upstream

flash1293 · 2020-10-30T11:01:36Z

@elasticmachine merge upstream

flash1293

Stacked charts are not supported yet (it requires some more design and features from the charting lib)

I know we made this decision but can you refresh my mind why that's the case? It looks like the values would like quite nice on stacked bars as well because they are only shown within the bar.

Histogram charts (time and number) are not supported yet

I probably missed that part - why can't we use this setting for histogram charts again?

x-pack/plugins/lens/public/xy_visualization/expression.tsx

flash1293 · 2020-10-30T11:09:55Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

+  }),
+  histogram: i18n.translate('xpack.lens.xyChart.valuesDisabledHelpText', {
+    defaultMessage:
+      'This setting cannot be applied to bar charts having time dimension on the x axis.',


This also applies to number histograms on the x axis, right?

flash1293 · 2020-10-30T11:13:51Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

@@ -386,6 +425,19 @@ export function XYChart({
    };
    return style;
  };
+  // Based on the XY toPreviewExpression logic


Let's move this logic to the toPreviewExpression function itself:

kibana/x-pack/plugins/lens/public/xy_visualization/to_expression.ts

Line 44 in 95bfb64

...state.legend,

Simply overwrite the state setting of show value labels with hide in there, then you don't need to detect a preview expression in here.

flash1293 · 2020-10-30T11:14:56Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

+              }
+            : { horizontal: HorizontalAlignment.Center },
+          offsetX: isHorizontal ? 10 : 0,
+          offsetY: isHorizontal ? 0 : -5,


This might be a personal feeling, but IMHO the labels are too close to the upper edge of the bar - can we go to -10 or something here?

flash1293 · 2020-10-30T11:22:31Z

Histogram with value labels:

Stacked bar with value labels:

Stacked histogram bar with value labels:

All of these look great IMHO

dej611 · 2020-10-30T11:32:39Z

Histogram with value labels:

Stacked bar with value labels:

Stacked histogram bar with value labels:

All of these look great IMHO

In general, I agree with you.

I think the main concern here is for histogram with tiny bars which may produce probably less nice results in some scenarios, and so stacked bars leading or dirty inconsistent result.

Some examples below:

Also stacked bars may have series which are too small to fit the label, so you may land on a stacked bar with some labels shown, and others not.

But I am open for discussion here. The route of this PR is based on the previous PR feedback, but nothing exclude to increase a bit the scope if we like it.

…a into feature/lens/value_labels_2

flash1293 · 2020-10-30T12:42:33Z

@dej611 I definitely see your point. So to rephrase (just to make sure I got it):

For splitted bars and histogram charts "broken" value labels are very common with the default configuration (very likely for a user to run into such a situation). While it's also possible to create unstacked bars with really weird labels, those happen less often so it's the right trade-off to roll out this feature just for the cases that work most of the time, and wait till elastic-charts has a better handling for value labels in general until rolling out the feature there as well.

(for reference, this is an unstacked bar chart with weird partial label placement)

flash1293 · 2020-10-30T13:59:31Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

@@ -73,6 +85,39 @@ const legendOptions: Array<{ id: string; value: 'auto' | 'show' | 'hide'; label:
  },
 ];

+// TODO: inside/outside logic requires some more work on the elastic-chart side


Nit: Let's track that outside of the code.

flash1293

Added some small comments, but that's looking pretty good, great work!

flash1293 · 2020-10-30T14:00:40Z

x-pack/plugins/lens/public/xy_visualization/types.ts

@@ -402,6 +409,7 @@ export interface XYArgs {
 export interface XYState {
  preferredSeriesType: SeriesType;
  legend: LegendConfig;
+  valueLabels: ValueLabelConfig;


As this is not optional, it changes the current state shape and we require a migration to make it work (existing saved objects won't have the valueLabels property. Let's either make it optional (and default the behavior to hide) or add the migration using the regular migration framework

flash1293 · 2020-10-30T14:03:36Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

+                  // This format double fixes two issues in elastic-chart
+                  // * when rotating the chart, the formatter is not correctly picked
+                  // * in some scenarios value labels are not strings, and this breaks the elastic-chart lib
+                  valueFormatter: (d: unknown) => yAxis?.formatter?.convert(d) || '',


Is this an elastic-charts bug? If yes we should open an issue for it. Also, it seems like this behavior is complex enough to cover it with a unit test.

The latter bug (non-string value handling) has been reported already. The former needs to be reported.

Gotcha, thanks for confirming. LGTM if it's tested and reported.

wylieconlon

Did some testing, but not complete code review

wylieconlon · 2020-10-30T22:57:11Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

+        ...theme.barSeriesStyle,
+        displayValue: {
+          fontSize: { min: VALUE_LABELS_MIN_FONTSIZE, max: VALUE_LABELS_MAX_FONTSIZE },
+          fill: { textInverted: true, textBorder: true },


I'm honestly finding the text to be more readable without the text border. I know we thought it was important earlier, but I'm rethinking this. Want to try without it?

I've ran some tests here with current styling, no border or increased border size.

Current border

Thicker border

No border

Personally I find the thicker version easier to read compared to both current state and no border at all (exp. with bars with lower contrast with the text). But I see no big readability gain for few bars or vertical charts with many bars.

@dej611 Thanks for showing the options, I share your opinion that the thicker border is the easiest of these options. Will you submit a PR to elastic-charts for this? cc @markov00

No need for a PR on the elastic-chart side.
The textBorder already accepts a number to increase the size of it. Will update this PR right now.

I was mostly suggesting it because I think having good defaults is important, and this looks like the kind of thing we would want to set by default for elastic-charts.

I'll open an issue on the repo

elastic-chart issue: elastic/elastic-charts#886

There are other considerations we should consider before baking this into Elastic Charts. I've commented separately on that issue.

wylieconlon · 2020-10-30T22:59:12Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

-            })}
-            condition={!hasNonBarSeries}
+            tooltipContent={tooltipContentValueLabels}
+            condition={!hasNonBarSeries && (!hasBarNotStacked || isHistogramSeries)}


I was honestly a bit confused by this as well, and it seems like @flash1293 was too. The problem is that we now have completely opposite settings. The "fill" settings are only for Line charts, and the "value labels" settings are only for bar charts. Because of this, I don't think we should ever disable the entire menu- I would like to always enable the menu, with help text on each individual setting. What do you think?

I think that's a good idea, @wylieconlon - seems like the current logic is too smart to stay easily understandable.

flash1293

Functionality wise this looks good to me (just left one nit), but I think we have to work on the labels:

Active state:

Display: Show/Hide seems confusing to me, what does "hiding" a "display" mean? - maybe "Labels"? maybe "Labels on chart"?

Not applicable because of histogram x axis:

Two problems with this label:

It's also shown when looking at a line chart (like in the screenshot), making the wording a bad fit
It's not only about time, it's also about number histograms

Suggestion: "This setting can only be used on categorical, un-stacked bar charts"

Not applicable because of chart type:

"Try other chart types" leaves the user guessing - where can they use it? Also the grammar seems weird (but take it with a grain of salt, my english skills are pretty bad)

Suggestion (same as for the other error case, simplifying the UI here): "This setting can only be used on categorical, un-stacked bar charts"

Feedback from native speakers appreciated (especially @gchaps)

flash1293 · 2020-11-03T09:00:54Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

+
+  const baseThemeWithMaybeValueLabels = !shouldShowValueLabels
+    ? chartTheme
+    : mergeThemeWithValueLabelsStyling(chartTheme, valueLabels || 'hide', shouldRotate);


nit: valueLabels should always be set, right?

I think so. I was thinking about backward compatibility here, but probably the expression evaluation should ensure that the value is set.

Yep, expressions are regenerated every time, so it's safe to assume it's available here because of the default value in to_expression

dej611 · 2020-11-03T11:16:43Z

Updated the messages as you suggested @flash1293 .
I will wait for the approval or improvements from @gchaps .

flash1293

Tested and LGTM. Left one UI nit

flash1293 · 2020-11-03T14:41:12Z

x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx

 }) => {
  const [open, setOpen] = useState(false);

  const iconType: string | IconType = typeof type === 'string' ? typeToIconMap[type] : type;
+  const panelClassName = larger ? 'lnsXyToolbar__popoverLarger' : 'lnsXyToolbar__popover';


Not sure about this workaround - maybe @MichaelMarcialis has an idea how to improve this.
For context: To show why an option in the popover is disabled, a tooltip icon is added, but it's slightly too large to fit into the same row for the standard width of these popovers, so it has to get enlarged:

The only thing I can think of is to put the tooltip on the disabled form element itself instead of an additional icon, then the popover is wide enough and we don't need a separate class. The downside is the missing affordance - does the user know they have to hover the form element to get a reason for it being disabled?

Just realized we have something like this in lens already - it looks like this for the colors:

No strong opinion which route to go but we should make sure to do it the same way in both places

The only thing I can think of is to put the tooltip on the disabled form element itself instead of an additional icon, then the popover is wide enough and we don't need a separate class. The downside is the missing affordance - does the user know they have to hover the form element to get a reason for it being disabled?

Yes, this was the reason of the conditional icon state. I'll update the PR with a better alignment 👍

Hey, all. If I'm understanding correctly, and the "missing values" field is one that will always be disabled when any visualization other than line and area are selected, my first instinct would be to conditionally remove that form field altogether in those instances. I'm not a fan of showing users disabled form fields where users have little-to-no ability to re-enable (assuming the currently selected visualization type is the desired one).

For example, if I know I want a bar chart for my visualization, why even present me with a field that I'll never be able to interact with?

Updated PR to hide the field when the chart is not of type area or line.
Also improved icon alignment as in the picture above for Series color.

…e_labels_2

ryankeairns

Code review only.

Left a comment regarding the text treatment and I see that @MichaelMarcialis was involved for a UX consideration. Let me know if other specific feedback is needed.

MichaelMarcialis

This is looking great! I've left two small comments/questions for your review.

Additionally, I was thinking about the current EuiIcon usage, shown in the screenshot below. That icon makes me think of a text box tool, rather than visualization value options. Would something like the number icon in EUI be a better fit?

MichaelMarcialis · 2020-11-05T01:58:13Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

+            <EuiFormRow
+              display="columnCompressed"
+              label={
+                <TooltipWrapper
+                  tooltipContent={i18n.translate(
+                    'xpack.lens.xyChart.valuesStackedDisabledHelpText',
+                    {
+                      defaultMessage:
+                        'This setting can only be used on categorical, un-stacked bar charts',
+                    }
+                  )}
+                  condition={isValueLabelsDisabled}
+                >
+                  <span>
+                    {i18n.translate('xpack.lens.shared.chartValueLabelVisibilityLabel', {
+                      defaultMessage: 'Labels',
+                    })}{' '}
+                    {isValueLabelsDisabled ? (
+                      <EuiIcon
+                        type="questionInCircle"
+                        color="subdued"
+                        size="s"
+                        className="eui-alignTop"
+                      />
+                    ) : null}
+                  </span>
+                </TooltipWrapper>
+              }
            >
+              <EuiButtonGroup
+                isFullWidth
+                legend={i18n.translate('xpack.lens.shared.chartValueLabelVisibilityLabel', {
+                  defaultMessage: 'Labels',
+                })}
+                isDisabled={isValueLabelsDisabled}
+                data-test-subj="lnsValueLabelsDisplay"
+                name="valueLabelsDisplay"
+                buttonSize="compressed"
+                options={valueLabelsOptions}
+                idSelected={
+                  valueLabelsOptions.find(({ value }) => value === valueLabelsVisibilityMode)!.id
+                }
+                onChange={(modeId) => {
+                  const newMode = valueLabelsOptions.find(({ id }) => id === modeId)!.value;
+                  setState({ ...state, valueLabels: newMode });
+                }}
+              />
+            </EuiFormRow>


@dej611, @flash1293: In relation to my previous comment, would it also make sense to only show this "Labels" form field when a user has selected a vertical or horizontal bar visualization (given the current limitations)? Again, doing so would prevent showing the user a disabled form field that they would be unable to re-enable, if they were to select a non-bar type visualization.

In the situation that all form fields within this popover would be hidden (for example, if a stacked bar visualization was selected), then I would suggest we then hide the parent "Values" button that the popover emanates from.

Thoughts?

It sounds we're likely back to square one here. :D
There's a plan to make value labels visible for all types of bars in the future: the way we handle this transition period (until the charting library supports more options or there's a decision to enable them as is) it's taking very long time to settle to a single UI, I think.

I do not have strong opinion here: it started with the button disabled and then enabled by request, so I do not mind either way.

I think we struggled with the whole hiding vs. disabling in a bunch of other places as well. What do y'all think about merging this PR to avoid ongoing maintenance costs, come to a conclusion for Lens in general, then making everything consistent in a separate PR? This is how we handled lots of ongoing changes in the UI previously a few times.

@flash1293: I'm fine with whatever approach you all deem best (either in this PR or a separate PR in the future). To be clear though, my concern is not about consistency.

@dej611: If the plan is to make the value labels option available for all bar-type visualizations in the future, then I would be fine with this form field being present whenever any bar-type visualization is selected, and simply disabling for now if it happens to be a stacked bar or histogram.

That said, what I would continue to find problematic is that this form field currently shows even when a non-bar visualization is selected. For example, this option continues to show for me (in a disabled state) when I've selected line, area, etc. Since a user can never interact with it for those non-bar visualization types, could we not hide it?

MichaelMarcialis · 2020-11-05T02:07:29Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

+                    'xpack.lens.xyChart.valuesStackedDisabledHelpText',
+                    {
+                      defaultMessage:
+                        'This setting can only be used on categorical, un-stacked bar charts',


Assuming my previous suggestion to conditionally hide this field is applied, we'll need to update this tooltip. Additionally, as a novice Lens user, it took me a few moments to understand what I had to do to my bar chart in order to be allowed to enable this setting. I'm wondering if verbiage such as this might make it clearer: This setting may be modified on categorical bar charts, but not histograms.

Someone else could likely better wordsmith this, but I think the notice that this is not for histogram-oriented bar charts makes it a bit more obvious. Thoughts?

Agree on the wording problem, but perhaps it could be addressed in a separate PR?

I'm fine if you would prefer to update this text in a separate PR.

flash1293 · 2020-11-05T14:38:34Z

@MichaelMarcialis @dej611 To summarize:

On all bar charts, show the "Labels" toggle
On stacked bars and histogram charts, disable it and show "This setting may be modified on categorical bar charts, but not histograms." as tooltip
On area/line, hide the "Labels" toggle
On area/line, show the "Missing values" select (always enabled state)
On bar charts, hide the "Missing values" select
Change the icon of the "Values" toolbar button to number

Sounds good to me.

dej611 · 2020-11-05T18:03:16Z

💄 Updated the button icon to EUI number
💄 Implemented show/hide/disable logic stated above in @flash1293 comment
🐛 Found that percentage area charts were not supported
- I kept that logic but will open an issue about that to discuss eventually to enable for it
- 💬 Created an ad hoc message for that
- ✅ Add tests to cover this case as well

MichaelMarcialis

Thanks so much for making these changes, @dej611! Approving.

gchaps · 2020-11-05T23:42:38Z

@flash1293 , @dej611

"Categorical, un-stacked bar charts" is a little hard to parse. How about:

This setting only applies to categorical bar charts that are not stacked.

If the control is greyed out, would it be ok to shorten these two lines:

This setting may be modified on area and stacked area charts, but not percentage area charts.
This setting may be modified on categorical bar charts, but not histograms.

To

This setting cannot be changed on percentage area charts.
This setting cannot be changed on histograms.

markov00 · 2020-11-06T10:07:47Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

+      barSeriesStyle: {
+        ...theme.barSeriesStyle,
+        displayValue: {
+          fontSize: { min: VALUE_LABELS_MIN_FONTSIZE, max: VALUE_LABELS_MAX_FONTSIZE },
+          fill: { textInverted: true, textBorder: 2 },
+          alignment: isHorizontal
+            ? {
+                vertical: VerticalAlignment.Middle,
+              }
+            : { horizontal: HorizontalAlignment.Center },
+          offsetX: isHorizontal ? VALUE_LABELS_HORIZONTAL_OFFSET : 0,
+          offsetY: isHorizontal ? 0 : VALUE_LABELS_VERTICAL_OFFSET,
+        },
+      },
+    },


As described here elastic/elastic-charts#886 (comment) we should move these changes into the EUI chart theme.
It can also be done after merging this PR.

dej611 · 2020-11-06T13:12:41Z

@elasticmachine merge upstream

kibanamachine · 2020-11-06T14:59:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6bac751

Metrics [docs]

async chunks size

id	before	after	diff
`lens`	1.0MB	1.0MB	+4.5KB

History

💚 Build #86334 succeeded 036bbde
💚 Build #86196 succeeded d9562aa
💚 Build #85784 succeeded b96c188
💔 Build #85757 failed 36a6c3e
💔 Build #85777 failed 1f6f324

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Kibana Machine <[email protected]>

…82849) Co-authored-by: Kibana Machine <[email protected]>

dej611 added 2 commits October 27, 2020 09:26

✨ First pass with chart values

cb9777a

✨ Almost completed implementation

db0d21b

dej611 added the Feature:Lens label Oct 28, 2020

dej611 added 3 commits October 28, 2020 18:02

🐛 + ✅ Fix pending checks issues + add tests

b5c55bb

✨ Add histogram check + refactor of some shared logic/types

95bfb64

🔧 Increase minimum font size

8bae6e6

✅ Add more tests for value labels corner cases

6f97d07

dej611 added v7.11.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:enhancement labels Oct 30, 2020

dej611 marked this pull request as ready for review October 30, 2020 09:43

dej611 requested a review from a team October 30, 2020 09:43

Merge branch 'master' into feature/lens/value_labels_2

8a3f7ff

Merge branch 'master' into feature/lens/value_labels_2

908160b

flash1293 reviewed Oct 30, 2020

View reviewed changes

dej611 added 2 commits October 30, 2020 12:44

👌 Incorporate review feedback

9a1173a

Merge branch 'feature/lens/value_labels_2' of github.com:dej611/kiban…

fe00a1b

…a into feature/lens/value_labels_2

♻️ Migrate to simpler expression

75d9013

flash1293 reviewed Oct 30, 2020

View reviewed changes

wylieconlon reviewed Oct 30, 2020

View reviewed changes

🐛 Resolve backward compatibility

47b1046

flash1293 reviewed Nov 3, 2020

View reviewed changes

🌐 + 👌 Revisited messages + remove unused value

25522d5

:world_with_meridians: fix i18n issue

f3d1ec1

flash1293 approved these changes Nov 3, 2020

View reviewed changes

dej611 added 5 commits November 4, 2020 11:54

💄 Hide missing fields row on bar charts + better icon alignment

36a6c3e

Merge remote-tracking branch 'upstream/master' into feature/lens/valu…

b46016c

…e_labels_2

🔥 Remove old cruft

b82da66

✅ Align tests to new UX

1f6f324

🏷️ Fix type issue

b96c188

ryankeairns approved these changes Nov 4, 2020

View reviewed changes

MichaelMarcialis reviewed Nov 5, 2020

View reviewed changes

👌 Implemented review feedback

d9562aa

MichaelMarcialis approved these changes Nov 5, 2020

View reviewed changes

:world_with_meridians: Change copy messages

036bbde

markov00 reviewed Nov 6, 2020

View reviewed changes

Merge branch 'master' into feature/lens/value_labels_2

6bac751

dej611 merged commit d3d3fa7 into elastic:master Nov 6, 2020

dej611 deleted the feature/lens/value_labels_2 branch November 6, 2020 15:34

dej611 added a commit to dej611/kibana that referenced this pull request Nov 6, 2020

[Lens] New value labels config option for bar charts (elastic#81776)

149aadd

Co-authored-by: Kibana Machine <[email protected]>

dej611 mentioned this pull request Nov 6, 2020

[7.x] [Lens] New value labels config option for bar charts (#81776) #82849

Merged

dej611 added a commit that referenced this pull request Nov 9, 2020

[7.x] [Lens] New value labels config option for bar charts (#81776) (#…

9af652e

…82849) Co-authored-by: Kibana Machine <[email protected]>

dej611 mentioned this pull request Nov 16, 2020

Integrate new XY Chart theme value labels styling elastic/eui#4267

Closed

ryankeairns mentioned this pull request Jan 14, 2021

Improve bar value styles on vis_type_xy charts #87991

Merged

1 task

dej611 mentioned this pull request Feb 22, 2023

[Lens] improve metric contrast with default status palette #151029

Closed

[Lens] New value labels config option for bar charts #81776

[Lens] New value labels config option for bar charts #81776

Conversation

dej611 commented Oct 27, 2020 • edited Loading

Summary

Checklist

dej611 commented Oct 29, 2020

Open questions:

elasticmachine commented Oct 30, 2020

dej611 commented Oct 30, 2020

flash1293 commented Oct 30, 2020

flash1293 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 commented Oct 30, 2020

dej611 commented Oct 30, 2020 • edited Loading

flash1293 commented Oct 30, 2020

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wylieconlon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Current border

Thicker border

No border

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

Active state:

Not applicable because of histogram x axis:

Not applicable because of chart type:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dej611 commented Nov 3, 2020

flash1293 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryankeairns left a comment

Choose a reason for hiding this comment

MichaelMarcialis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 commented Nov 5, 2020

dej611 commented Nov 5, 2020

MichaelMarcialis left a comment

Choose a reason for hiding this comment

gchaps commented Nov 5, 2020

markov00 Nov 6, 2020 • edited Loading

Choose a reason for hiding this comment

dej611 commented Nov 6, 2020

kibanamachine commented Nov 6, 2020

💚 Build Succeeded

Metrics [docs]

dej611 commented Oct 27, 2020 •

edited

Loading

dej611 commented Oct 30, 2020 •

edited

Loading

markov00 Nov 6, 2020 •

edited

Loading