Vega visualization renderer #81606
Merged
Vega visualization renderer #81606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/plugins/vis_type_vega/public/vega_fn.ts
13 tasks
sulemanof
added
release_note:skip
sulemanof
requested review from
alexwizp,
DianaDerevyankina,
VladLasitsa and
stratoula
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunk count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
alexwizp
reviewed
Oct 28, 2020
| } | ||
| await this._vegaView.init(); | ||
| await this.vegaView?.init(); |
There was a problem hiding this comment.
I think here should be await this.vegaView!.init(); I prefer to see error if for some reasons this.vegaView is null. But not sure that this case is possible
cchaos
approved these changes
Oct 28, 2020
stratoula
approved these changes
Oct 29, 2020
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Oct 29, 2020
* Create vega to_ast function * Create a custom vega renderer * Fix sass error Co-authored-by: Kibana Machine <[email protected]>
sulemanof
added a commit
that referenced
this pull request
Oct 29, 2020
* Create vega to_ast function * Create a custom vega renderer * Fix sass error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #46801
Vegavisualization.VegaVisComponent,VegaVisEditorandVegaDataInspectorcomponentstoExpressionAstfunction for building pipeline.vega_visualizationconverted into typescriptChecklist
Delete any items that are not applicable to this PR.
For maintainers