[data.search.aggs] Throw an error when trying to create an agg type that doesn't exist. #81509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Aggregations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Haha. I'm pushing us over the edge with 34.0B. I think there's another PR open which adjusts our limit, will rerun once that's merged. |
lukasolson
approved these changes
Oct 26, 2020
lukasolson
reviewed
Oct 26, 2020
| const aggType = typeof type === 'string' ? this.typesRegistry.get(type) : type; | ||
|
|
||
| if (!aggType) { | ||
| throw new Error(`Unable to find a registered agg type for "${type}"`); |
There was a problem hiding this comment.
Do we need to i18n this since it's shown in an error pop-up?
lukeelmers
force-pushed
the
fix/aggs-check-type
branch
from
d6c878d to
68eca6a
Compare
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
lukeelmers
force-pushed
the
fix/aggs-check-type
branch
2 times, most recently
from
14a4878 to
99002de
Compare
lukeelmers
force-pushed
the
fix/aggs-check-type
branch
from
99002de to
d4d93af
Compare
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 10, 2020
* master: (39 commits) Fix ilm navigation (elastic#81664) [Lens] Distinct icons for XY and pie chart value labels toolbar (elastic#82927) [data.search.aggs] Throw an error when trying to create an agg type that doesn't exist. (elastic#81509) Index patterns api - load field list on server (elastic#82629) New events resolver (elastic#82170) [App Search] Misc naming tech debt (elastic#82770) load empty_kibana in test to have clean starting point (elastic#82772) Remove data <--> expressions circular dependencies. (elastic#82685) Update 8.0 breaking change template to gather information on how to programmatically detect it. (elastic#82905) Add alerting as codeowners to related documentation folder (elastic#82777) Add captions to user and space grid pages (elastic#82713) add alternate path for x-pack/Cloud test for Lens (elastic#82634) Uses asCurrentUser in getClusterUuid (elastic#82908) [Alerting][Connectors] Add new executor subaction to get 3rd party case fields (elastic#82519) Fix test import objects (elastic#82767) [ML] Add option for anomaly charts for metric detector should plot min, mean or max as appropriate (elastic#81662) Update alert type selection layout to rows instead of grid (elastic#73665) Prevent Kerberos and PKI providers from initiating a new session for unauthenticated XHR/API requests. (elastic#82817) Update grunt and related packages (elastic#79327) Allow the repository to search across all namespaces (elastic#82863) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77423 we introduced a
shard_delayagg type that exists for testing purposes, and is conditionally enabled via yml config.This represents the first time we may have an agg stored in a visualization saved object which won't actually exist at runtime. In this case we should throw a clear error rather than waiting for
AggConfigto break when it attempts to create an agg of typeundefined.This PR adds a check that throws an error if no matching agg type is found in the registry when someone calls
createAggConfig