Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): kibana_path_conf deprecated usage #81500

Merged
merged 11 commits into from
Nov 9, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Oct 22, 2020

Closes #81474

It solves a missing usage we left behind of KIBANA_PATH_CONF in the main kibana bin script.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.10.1 labels Oct 22, 2020
@mistic mistic requested a review from a team as a code owner October 22, 2020 15:33
@mistic mistic self-assigned this Oct 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from tylersmalley October 22, 2020 16:06
@mistic

This comment has been minimized.

@mistic

This comment has been minimized.

1 similar comment
@mistic

This comment has been minimized.

@mistic

This comment has been minimized.

1 similar comment
@mistic

This comment has been minimized.

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm okay with forgoing the fallback to KIBANA_PATH_CONF here, this feature was never documented

@mistic
Copy link
Member Author

mistic commented Oct 28, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 2, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 4, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 4, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 4, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 6, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@mistic are you waiting for another review or is this good to merge?

@mistic
Copy link
Member Author

mistic commented Nov 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 9, 2020

going to merge it @tylersmalley

@mistic
Copy link
Member Author

mistic commented Nov 9, 2020

7.x/7.11: 6795350
7.10/7.10.1: c572e49

mistic added a commit that referenced this pull request Nov 9, 2020
… script (#81500) (#82967)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
mistic added a commit that referenced this pull request Nov 9, 2020
… script (#81500) (#82966)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node.options ignored on Kibana installed via RPM
5 participants