-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Migrate Warm phase to Form Lib #81323
Merged
jloleysens
merged 23 commits into
elastic:master
from
jloleysens:ilm/migrate-warm-phase-to-formlib
Oct 27, 2020
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d844b12
migrate all fields on warm phase except, data alloc, replicas and shrink
jloleysens e867ffe
introduce edit policy context to share original policy and migrate sh…
jloleysens d349eee
Refactored biggest field; data allocation
jloleysens 779534e
remove unused import
jloleysens 5bb0be9
complete migration of new serialization
jloleysens 98bf14b
Remove last vestiges of legacy warm phase
jloleysens 0121411
fix existing test coverage and remove use of "none" for node attribute
jloleysens d7896d7
added policy serialization tests
jloleysens 805a55d
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-w…
jloleysens 4f2a615
remove unused translations
jloleysens 2ed016f
Fix use of useFormData after update
jloleysens 5aed5cf
fix import path
jloleysens 271351e
Merge branch 'master' into ilm/migrate-warm-phase-to-formlib
kibanamachine db3894d
Merge branch 'master' into ilm/migrate-warm-phase-to-formlib
kibanamachine 7b2f0ba
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-w…
jloleysens 1affb8e
simplify serialization snapshot tests
jloleysens 97da20e
type phases: string -> phases: Phases
jloleysens 2befd67
Addressed some PR review items
jloleysens 96e45ae
updated data tier callout logic after new changes
jloleysens cb03877
getPolicy -> updatePolicy
jloleysens 6109d3a
fix detection of migrate false and refactor serialization to pure fun…
jloleysens 750992e
fix type issue
jloleysens b85f492
fix for correctly detecting policy data tier type
jloleysens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if we call twice this method in a test? It seems that the first time the switch would be "on" and the second time "off" and we would not be able to set thevalue. I think this is why we had the option to pass the
checked
value originally (to "toggleForceMerge" for e.g.).I think that for toggles we could use the handler from
testBed
WDYT?