Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New events resolver #80850

Merged
merged 7 commits into from
Oct 20, 2020
Merged

New events resolver #80850

merged 7 commits into from
Oct 20, 2020

Conversation

IgorGuz2000
Copy link
Contributor

@IgorGuz2000 IgorGuz2000 commented Oct 16, 2020 •
edited
Loading

Summary

Added one test for the event.library

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@IgorGuz2000 IgorGuz2000 added Feature:Resolver Security Solution Resolver feature v7.10.0 labels Oct 16, 2020
@IgorGuz2000 IgorGuz2000 requested review from a team as code owners October 16, 2020 15:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@IgorGuz2000 IgorGuz2000 added release_note:fix Team:Endpoint Data Visibility Team managing the endpoint resolver labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@IgorGuz2000
Copy link
Contributor Author

@elasticmachine merge upstream

charlie-pichette
charlie-pichette reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorGuz2000,

I would suggest you leave the expected data as a constant.

x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

charlie-pichette
charlie-pichette approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@IgorGuz2000 IgorGuz2000 merged commit 35404b4 into elastic:master Oct 20, 2020
@IgorGuz2000 IgorGuz2000 mentioned this pull request Oct 20, 2020
Merged
IgorGuz2000 added a commit to IgorGuz2000/kibana that referenced this pull request Oct 20, 2020
@IgorGuz2000 @kibanamachine
New events resolver (elastic#80850)
95082b6 
* Added Test for event.library

* renamed data directry and gzip data file

* rename expectedData file

* Changes per Charlie request

Co-authored-by: Kibana Machine <[email protected]>
IgorGuz2000 added a commit that referenced this pull request Oct 20, 2020
@IgorGuz2000 @kibanamachine
New events resolver (#80850) (#81232)
1ede936 
* Added Test for event.library

* renamed data directry and gzip data file

* rename expectedData file

* Changes per Charlie request

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-pichette charlie-pichette charlie-pichette approved these changes

@EricDavisX EricDavisX Awaiting requested review from EricDavisX

@achuguy achuguy Awaiting requested review from achuguy

Assignees
No one assigned
Labels
Feature:Resolver Security Solution Resolver feature release_note:fix Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgorGuz2000 @elasticmachine @kibanamachine @charlie-pichette