Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed less variable #7982

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Conversation

szydan
Copy link
Contributor

@szydan szydan commented Aug 11, 2016

Just a small PR to rename less variable according the TODO found in the code

// TODO: Rename `@input-border-radius` to `@input-border-radius-base` in v4

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Aug 17, 2016

Looks fine to me, but I don't have to clear a view how consistent we are in naming less-vars to begin with. @cjcenizal @bevacqua, could one of you take a look as well?

Nice to see a todo disappear though! Musing here, but ideally, we'd track outstanding tasks in github iso. the code...

@bevacqua
Copy link
Contributor

Probably should be @cjcenizal who reviews, I'm not sure what his reasoning was for the TODO item.

@cjcenizal
Copy link
Contributor

This comment was written by the Bootstrap dev team, and got carried over when we copy/pasted the source, so technically it doesn't pertain to Kibana. That being said, this is now technically our code, not Bootstrap's, and changes like these are exactly the reason we removed the Bootstrap dependency.

It looks like all the references were caught, and there's a very minimal risk this breaks anything. So, I say, let's merge it!

Thanks for your contribution, @szydan! LGTM.

@cjcenizal
Copy link
Contributor

@bevacqua Your thoughts?

@bevacqua
Copy link
Contributor

LGTM

@bevacqua bevacqua removed their assignment Aug 17, 2016
@cjcenizal cjcenizal merged commit ee80ced into elastic:master Aug 17, 2016
@szydan szydan deleted the renamed-less-variable branch November 17, 2016 12:27
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants