Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Change path to fix breaking integration test #79724

Merged

Conversation

neptunian
Copy link
Contributor

In https://github.com/elastic/kibana/pull/79193/files, routes were changed to remove ingest_manager. This fixes an integration added just after the former was merged in #79579.

@neptunian neptunian added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 6, 2020
@neptunian neptunian self-assigned this Oct 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79724 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 8, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79724 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79724 or prevent reminders by adding the backport:skip label.

@jfsiii
Copy link
Contributor

jfsiii commented Oct 12, 2020

@neptunian @nchaulet I think we want to backport this, right? It's not one of the acks, checkin, or enroll routes which had both ingest_manager & fleet is it?

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79724 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79724 or prevent reminders by adding the backport:skip label.

@jfsiii
Copy link
Contributor

jfsiii commented Oct 15, 2020

I tried to backport this and got this error:

node scripts/backport --pr  79724
? Select pull request Fixes Fleet API path (#79724)
? Select branch 7.x, 7.10

Backporting to 7.x:
✔ Pulling latest changes
✖ Cherry-picking: Fixes Fleet API path (#79724)
Cherrypick failed because the selected commit (68c6aa74) is empty. Did you already backport this commit?

Backporting to 7.10:
✔ Pulling latest changes
✖ Cherry-picking: Fixes Fleet API path (#79724)
Cherrypick failed because the selected commit (68c6aa74) is empty. Did you already backport this commit?

@ph @jen-huang should we add backport:skip or do something else?

@neptunian
Copy link
Contributor Author

neptunian commented Oct 15, 2020

@tylersmalley Not sure what happened here, but did you backport these somehow? I got the same result as above.

@tylersmalley
Copy link
Contributor

@neptunian, I believe you hadn't merged the backport yet and addressed there: #79648

At the time this was only affecting master.

@neptunian
Copy link
Contributor Author

Adding backport skip label. Confirmed changes are in 7.10 and 7.x. Sorry all!

@neptunian neptunian added the backport:skip This commit does not require backporting label Oct 15, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants