Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix use correct mount-context #79688

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[Maps] fix use correct mount-context #79688

merged 2 commits into from
Oct 6, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 6, 2020

Fixes #79302

mount function should not get context parameter. Maps application was not even using context parameter so the fix was as simple as removing it.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 6, 2020
@nreese nreese requested a review from thomasneirynck October 6, 2020 15:43
@nreese nreese requested a review from a team as a code owner October 6, 2020 15:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Oct 6, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
maps 3.2MB 3.2MB -12.0B

page load bundle size

id before after diff
maps 164.7KB 164.7KB -16.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! code review.

@nreese nreese merged commit ab42ca2 into elastic:master Oct 6, 2020
nreese added a commit to nreese/kibana that referenced this pull request Oct 6, 2020
@nreese @kibanamachine
[Maps] fix use correct mount-context (elastic#79688)
3cf9e1e 
Co-authored-by: Kibana Machine <[email protected]>
@nreese nreese mentioned this pull request Oct 6, 2020
Merged
nreese added a commit that referenced this pull request Oct 6, 2020
@nreese @kibanamachine
[Maps] fix use correct mount-context (#79688) (#79778)
2a7934a 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] use correct mount-context
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck